Touch gestures for System Tray/ IME/ Stylus/ Notifications

ui/views/bubble/tray_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_TRAY_BUBBLE_VIEW_H_
 #define UI_VIEWS_BUBBLE_TRAY_BUBBLE_VIEW_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 30 matching lines @@
     ANCHOR_ALIGNMENT_BOTTOM,
     ANCHOR_ALIGNMENT_LEFT,
     ANCHOR_ALIGNMENT_RIGHT,
   };
 
   class VIEWS_EXPORT Delegate {
    public:
     typedef TrayBubbleView::AnchorAlignment AnchorAlignment;
 
     Delegate() {}
     virtual ~Delegate() {}

[msw, 2017/07/17 20:45:03]

optional nit: move this to the cc file too.

[minch1, 2017/07/18 03:59:00]

Done.

 
     // Called when the view is destroyed. Any pointers to the view should be
     // cleared when this gets called.
-    virtual void BubbleViewDestroyed() = 0;
+    virtual void BubbleViewDestroyed();
 
     // Called when the mouse enters/exits the view.
     // Note: This event will only be called if the mouse gets actively moved by
     // the user to enter the view.
-    virtual void OnMouseEnteredView() = 0;
-    virtual void OnMouseExitedView() = 0;
+    virtual void OnMouseEnteredView();
+    virtual void OnMouseExitedView();
 
     // Called to register/unregister accelerators for TrayBubbleView.
     // TrayBubbleView wants to register those accelerators at the global level.
     // Those accelerators are used to activate TrayBubbleView, i.e. those
     // accelerators need to be processed even if TrayBubbleView is not active.
     // UnregisterAllAccelerators can be called even if RegisterAccelerators is
     // not called.
     virtual void RegisterAccelerators(
         const std::vector<ui::Accelerator>& accelerators,
-        TrayBubbleView* tray_bubble_view) = 0;
-    virtual void UnregisterAllAccelerators(
-        TrayBubbleView* tray_bubble_view) = 0;
+        TrayBubbleView* tray_bubble_view);
+    virtual void UnregisterAllAccelerators(TrayBubbleView* tray_bubble_view);
 
     // Called from GetAccessibleNodeData(); should return the appropriate
     // accessible name for the bubble.
-    virtual base::string16 GetAccessibleNameForBubble() = 0;
+    virtual base::string16 GetAccessibleNameForBubble();
 
     // Should return true if extra keyboard accessibility is enabled.
     // TrayBubbleView will put focus on the default item if extra keyboard
     // accessibility is enabled.
-    virtual bool ShouldEnableExtraKeyboardAccessibility() = 0;
+    virtual bool ShouldEnableExtraKeyboardAccessibility();
 
     // Called when a bubble wants to hide/destroy itself (e.g. last visible
     // child view was closed).
-    virtual void HideBubble(const TrayBubbleView* bubble_view) = 0;
+    virtual void HideBubble(const TrayBubbleView* bubble_view);
+
+    virtual bool ProcessGestureEventForBubble(ui::GestureEvent* event);

[tdanderson, 2017/07/17 22:44:38]

Please add some documentation here for this new function.

[minch1, 2017/07/18 03:59:00]

Done.

 
    private:
     DISALLOW_COPY_AND_ASSIGN(Delegate);
   };
 
   struct VIEWS_EXPORT InitParams {
     InitParams();
     InitParams(const InitParams& other);
     Delegate* delegate = nullptr;
     gfx::NativeWindow parent_window = nullptr;
@@ skipping 54 matching lines @@
                                 Widget* bubble_widget) const override;
   void OnWidgetClosing(Widget* widget) override;
 
   // Overridden from views::View.
   gfx::Size CalculatePreferredSize() const override;
   gfx::Size GetMaximumSize() const override;
   int GetHeightForWidth(int width) const override;
   void OnMouseEntered(const ui::MouseEvent& event) override;
   void OnMouseExited(const ui::MouseEvent& event) override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+  void OnGestureEvent(ui::GestureEvent* event) override;
 
   // Overridden from MouseWatcherListener
   void MouseMovedOutOfHost() override;
 
   // Overridden from ui::AcceleratorTarget
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
 
  protected:
   // Overridden from views::BubbleDialogDelegateView.
   int GetDialogButtons() const override;
@@ skipping 28 matching lines @@
 
   // Used to find any mouse movements.
   std::unique_ptr<MouseWatcher> mouse_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(TrayBubbleView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_TRAY_BUBBLE_VIEW_H_