[CrOS Tether] NetworkList: Remove code which erroneously added Tether networks twice.

[CrOS Tether] NetworkList: Remove code which erroneously added Tether networks twice.

Tether networks are already included when NetworkStateHandler::GetVisibleNetworkList() is called, so they should not be added twice. This error caused a crash because NetworkList contains several maps from network GUID to another object, and these maps would get out of sync when two networks with the same GUID were included.

This CL also removes some unnecessary code which skipped adding Wi-Fi networks which have a tether GUID set. This can no longer happen, since those networks are never returned from NetworkStateHandler after https://codereview.chromium.org/2945643002/.

BUG=672263, 737654
Review-Url: https://codereview.chromium.org/2961153003
Cr-Commit-Position: refs/heads/master@{#483249}
Committed: https://chromium.googlesource.com/chromium/src/+/ba110b86fcda72e706d03f46c75976018aa80d63

[Kyle Horimoto, 2017-06-28 20:57:38]

khorimoto@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-06-28 22:13:21]

lgtm

[Kyle Horimoto, 2017-06-28 23:02:07]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-28 23:02:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 01:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 01:03:35]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))

[Kyle Horimoto, 2017-06-29 01:06:50]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-29 01:07:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 01:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498698410442100, "parent_rev":
"5ce70fb6cd232f158065678e9175bfb45cfc28b5", "commit_rev":
"ba110b86fcda72e706d03f46c75976018aa80d63"}

[commit-bot: I haz the power, 2017-06-29 01:50:21]

Description was changed from

==========
[CrOS Tether] NetworkList: Remove code which erroneously added Tether networks
twice.

Tether networks are already included when
NetworkStateHandler::GetVisibleNetworkList() is called, so they should not be
added twice. This error caused a crash because NetworkList contains several maps
from network GUID to another object, and these maps would get out of sync when
two networks with the same GUID were included.

This CL also removes some unnecessary code which skipped adding Wi-Fi networks
which have a tether GUID set. This can no longer happen, since those networks
are never returned from NetworkStateHandler after
https://codereview.chromium.org/2945643002/.

BUG=672263,737654
==========

to

==========
[CrOS Tether] NetworkList: Remove code which erroneously added Tether networks
twice.

Tether networks are already included when
NetworkStateHandler::GetVisibleNetworkList() is called, so they should not be
added twice. This error caused a crash because NetworkList contains several maps
from network GUID to another object, and these maps would get out of sync when
two networks with the same GUID were included.

This CL also removes some unnecessary code which skipped adding Wi-Fi networks
which have a tether GUID set. This can no longer happen, since those networks
are never returned from NetworkStateHandler after
https://codereview.chromium.org/2945643002/.

BUG=672263,737654

Review-Url: https://codereview.chromium.org/2961153003
Cr-Commit-Position: refs/heads/master@{#483249}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba110b86fcda72e706d03f46c759...
==========

[commit-bot: I haz the power, 2017-06-29 01:50:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba110b86fcda72e706d03f46c759...