Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2961063002: Allow trailing comma in assert (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 3 chunks +15 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-28 15:05:24 UTC) #2
danrubel
LGTM
3 years, 5 months ago (2017-06-28 15:23:36 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-06-28 17:46:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
563720617c9a25dba653a2eddeebe42000556789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698