Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: pkg/analyzer/test/generated/parser_test.dart

Issue 2961063002: Allow trailing comma in assert (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analyzer/dart/ast/ast.dart'; 5 import 'package:analyzer/dart/ast/ast.dart';
6 import 'package:analyzer/dart/ast/standard_ast_factory.dart'; 6 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
7 import 'package:analyzer/dart/ast/token.dart'; 7 import 'package:analyzer/dart/ast/token.dart';
8 import 'package:analyzer/dart/ast/visitor.dart'; 8 import 'package:analyzer/dart/ast/visitor.dart';
9 import 'package:analyzer/error/error.dart'; 9 import 'package:analyzer/error/error.dart';
10 import 'package:analyzer/error/listener.dart'; 10 import 'package:analyzer/error/listener.dart';
(...skipping 12248 matching lines...) Expand 10 before | Expand all | Expand 10 after
12259 assertNoErrors(); 12259 assertNoErrors();
12260 expect(statement.assertKeyword, isNotNull); 12260 expect(statement.assertKeyword, isNotNull);
12261 expect(statement.leftParenthesis, isNotNull); 12261 expect(statement.leftParenthesis, isNotNull);
12262 expect(statement.condition, isNotNull); 12262 expect(statement.condition, isNotNull);
12263 expect(statement.comma, isNotNull); 12263 expect(statement.comma, isNotNull);
12264 expect(statement.message, isNotNull); 12264 expect(statement.message, isNotNull);
12265 expect(statement.rightParenthesis, isNotNull); 12265 expect(statement.rightParenthesis, isNotNull);
12266 expect(statement.semicolon, isNotNull); 12266 expect(statement.semicolon, isNotNull);
12267 } 12267 }
12268 12268
12269 void test_parseAssertStatement_trailingComma_message() {
12270 var statement = parseStatement('assert (x, "m",);') as AssertStatement;
12271 assertNoErrors();
12272 expect(statement.assertKeyword, isNotNull);
12273 expect(statement.leftParenthesis, isNotNull);
12274 expect(statement.condition, isNotNull);
12275 expect(statement.comma, isNotNull);
12276 expect(statement.message, isNotNull);
12277 expect(statement.rightParenthesis, isNotNull);
12278 expect(statement.semicolon, isNotNull);
12279 }
12280
12281 void test_parseAssertStatement_trailingComma_noMessage() {
12282 var statement = parseStatement('assert (x,);') as AssertStatement;
12283 assertNoErrors();
12284 expect(statement.assertKeyword, isNotNull);
12285 expect(statement.leftParenthesis, isNotNull);
12286 expect(statement.condition, isNotNull);
12287 expect(statement.comma, isNull);
12288 expect(statement.message, isNull);
12289 expect(statement.rightParenthesis, isNotNull);
12290 expect(statement.semicolon, isNotNull);
12291 }
12292
12269 void test_parseBlock_empty() { 12293 void test_parseBlock_empty() {
12270 var block = parseStatement('{}') as Block; 12294 var block = parseStatement('{}') as Block;
12271 assertNoErrors(); 12295 assertNoErrors();
12272 expect(block.leftBracket, isNotNull); 12296 expect(block.leftBracket, isNotNull);
12273 expect(block.statements, hasLength(0)); 12297 expect(block.statements, hasLength(0));
12274 expect(block.rightBracket, isNotNull); 12298 expect(block.rightBracket, isNotNull);
12275 } 12299 }
12276 12300
12277 void test_parseBlock_nonEmpty() { 12301 void test_parseBlock_nonEmpty() {
12278 var block = parseStatement('{;}') as Block; 12302 var block = parseStatement('{;}') as Block;
(...skipping 2886 matching lines...) Expand 10 before | Expand all | Expand 10 after
15165 expectCommentText(typeVariable.documentationComment, '/// Doc'); 15189 expectCommentText(typeVariable.documentationComment, '/// Doc');
15166 } 15190 }
15167 15191
15168 /** 15192 /**
15169 * Assert that the given [name] is in declaration context. 15193 * Assert that the given [name] is in declaration context.
15170 */ 15194 */
15171 void _assertIsDeclarationName(SimpleIdentifier name) { 15195 void _assertIsDeclarationName(SimpleIdentifier name) {
15172 expect(name.inDeclarationContext(), isTrue); 15196 expect(name.inDeclarationContext(), isTrue);
15173 } 15197 }
15174 } 15198 }
OLDNEW
« no previous file with comments | « pkg/analyzer/test/generated/parser_fasta_test.dart ('k') | tests/language/language_analyzer2.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698