Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2961053002: [objects] Move AllocationSite::MakePretenureDecision() and AllocationSite::DigestPretenuringFeedbac… (Closed)

Created:
3 years, 5 months ago by titzer
Modified:
3 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[objects] Move AllocationSite::MakePretenureDecision() and AllocationSite::DigestPretenuringFeedback() into heap.cc These two methods were only called in heap.cc. Since they are pretty heavyweight and objects-inl.h is included in many V8 files, this saves build time. R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2961053002 Cr-Commit-Position: refs/heads/master@{#46290} Committed: https://chromium.googlesource.com/v8/v8/+/e44c607b81024cb0eb71783b0e55840c1744ce32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M src/heap/heap.cc View 2 chunks +60 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
3 years, 5 months ago (2017-06-28 13:57:55 UTC) #1
ulan
lgtm
3 years, 5 months ago (2017-06-28 14:05:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961053002/1
3 years, 5 months ago (2017-06-28 14:28:58 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 14:32:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e44c607b81024cb0eb71783b0e55840c174...

Powered by Google App Engine
This is Rietveld 408576698