Add Superfish interstitial to chrome://interstitials

Add Superfish interstitial to chrome://interstitials

BUG=736166
TEST=Visit chrome://interstitials and click the "Superfish" link

Review-Url: https://codereview.chromium.org/2961013004
Cr-Commit-Position: refs/heads/master@{#483119}
Committed: https://chromium.googlesource.com/chromium/src/+/9da8b8189b5a1de18665ca383658da498dd1796a

[estark, 2017-06-28 17:56:35]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:56:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-06-28 17:56:57]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2017-06-28 17:56:58]

meacer, PTAL? Thanks!

[meacer, 2017-06-28 17:59:25]

Looks good. Can you also add a test to interstitial_ui_browsertest.cc?

https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
File
components/security_interstitials/core/browser/resources/list_of_interstitials.html
(right):

https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
components/security_interstitials/core/browser/resources/list_of_interstitials.html:46:
<li>
Extra indentation

[estark, 2017-06-28 18:25:30]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 18:25:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-06-28 18:26:12]

On 2017/06/28 17:59:25, meacer wrote:
> Looks good. Can you also add a test to interstitial_ui_browsertest.cc?

Ah, didn't know we had those. Done.

> 
>
https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
> File
>
components/security_interstitials/core/browser/resources/list_of_interstitials.html
> (right):
> 
>
https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
>
components/security_interstitials/core/browser/resources/list_of_interstitials.html:46:
> <li>
> Extra indentation

[estark, 2017-06-28 18:26:17]

https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
File
components/security_interstitials/core/browser/resources/list_of_interstitials.html
(right):

https://codereview.chromium.org/2961013004/diff/1/components/security_interst...
components/security_interstitials/core/browser/resources/list_of_interstitials.html:46:
<li>
On 2017/06/28 17:59:25, meacer wrote:
> Extra indentation

Done.

[meacer, 2017-06-28 18:31:11]

Lgtm

[estark, 2017-06-28 18:32:42]

The CQ bit was unchecked by estark@chromium.org

[estark, 2017-06-28 18:32:48]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:33:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 20:33:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498674768975660,
"parent_rev": "5f2416490dad11ff130aaaba5285f13af1f6ed62", "commit_rev":
"9da8b8189b5a1de18665ca383658da498dd1796a"}

[commit-bot: I haz the power, 2017-06-28 20:34:06]

Description was changed from

==========
Add Superfish interstitial to chrome://interstitials

BUG=736166
TEST=Visit chrome://interstitials and click the "Superfish" link
==========

to

==========
Add Superfish interstitial to chrome://interstitials

BUG=736166
TEST=Visit chrome://interstitials and click the "Superfish" link

Review-Url: https://codereview.chromium.org/2961013004
Cr-Commit-Position: refs/heads/master@{#483119}
Committed:
https://chromium.googlesource.com/chromium/src/+/9da8b8189b5a1de18665ca383658...
==========

[commit-bot: I haz the power, 2017-06-28 20:34:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9da8b8189b5a1de18665ca383658...