Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2961013003: Revert of Rerecorded browse:news:toi (Closed)

Created:
3 years, 5 months ago by ashleymarie1
Modified:
3 years, 5 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rerecorded browse:news:toi (patchset #2 id:20001 of https://codereview.chromium.org/2959743003/ ) Reason for revert: Looks like this recording didn't fix the bug It's running and failing here: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf/builds/227 Original issue's description: > Rerecorded browse:news:toi > > BUG=chromium:728081 > > Review-Url: https://codereview.chromium.org/2959743003 > Cr-Commit-Position: refs/heads/master@{#482663} > Committed: https://chromium.googlesource.com/chromium/src/+/7c12598ed00f30cc125b9af98a7826edcbf47a39 TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:728081 Review-Url: https://codereview.chromium.org/2961013003 Cr-Commit-Position: refs/heads/master@{#482963} Committed: https://chromium.googlesource.com/chromium/src/+/8a0a93fdbca72e4455bc3dd876e28bf88473433b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/perf/page_sets/data/system_health_mobile_064.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/system_health/expectations.py View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ashleymarie1
Created Revert of Rerecorded browse:news:toi
3 years, 5 months ago (2017-06-28 13:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961013003/1
3 years, 5 months ago (2017-06-28 13:17:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-06-28 13:17:07 UTC) #5
nednguyen
lgtm
3 years, 5 months ago (2017-06-28 13:18:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2961013003/1
3 years, 5 months ago (2017-06-28 13:19:08 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 13:19:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a0a93fdbca72e4455bc3dd876e2...

Powered by Google App Engine
This is Rietveld 408576698