Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2961003002:
Prevent plugins from changing mouse cursor during middle-click autoscroll. (Closed)
|
Created:
3 years, 5 months ago by aelias_OOO_until_Jul13 Modified:
3 years, 5 months ago Reviewers:
bokan CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, dtapuska+blinkwatch_chromium.org, jam, kinuko+watch, mlamouri+watch-content_chromium.org, Navid Zolghadr, platform-architecture-syd+reviews-web_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrevent plugins from changing mouse cursor during middle-click autoscroll.
Cursor updates were suppressed in EventHandler, but this doesn't
work for plugins which call SetCursorForPlugin directly on ChromeClient.
This was a preexisting bug, but it got worse with the recent rewrite
because the bug used to be mostly covered up by the old implementation
pushing cursor updates at 60fps.
BUG=735865
Review-Url: https://codereview.chromium.org/2961003002
Cr-Commit-Position: refs/heads/master@{#483259}
Committed: https://chromium.googlesource.com/chromium/src/+/be5aadf1dfe860773906916f583270793e45db3d
Patch Set 1 #Patch Set 2 : Clean up and rebase #Patch Set 3 : Fix layout tests #Patch Set 4 : Rebase #
Messages
Total messages: 30 (22 generated)
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [WIP] Cursor override middle-click autoscroll BUG=735865 ========== to ========== Prevent plugins from changing mouse cursor during middle-click autoscroll. Cursor updates were suppressed in EventHandler, but this doesn't work for plugins which call SetCursorForPlugin directly on ChromeClient. This was a preexisting bug, but it got worse with the recent rewrite because the bug used to be mostly covered up by the old implementation pushing cursor updates at 60fps. BUG=735865 ==========
aelias@chromium.org changed reviewers: + bokan@chromium.org
Hi bokan@, PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm
The CQ bit was checked by aelias@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by aelias@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org Link to the patchset: https://codereview.chromium.org/2961003002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by aelias@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498698654979700,
"parent_rev": "dbf773464704499610b86e6df03a97303521548a", "commit_rev":
"be5aadf1dfe860773906916f583270793e45db3d"}
Message was sent while issue was closed.
Description was changed from ========== Prevent plugins from changing mouse cursor during middle-click autoscroll. Cursor updates were suppressed in EventHandler, but this doesn't work for plugins which call SetCursorForPlugin directly on ChromeClient. This was a preexisting bug, but it got worse with the recent rewrite because the bug used to be mostly covered up by the old implementation pushing cursor updates at 60fps. BUG=735865 ========== to ========== Prevent plugins from changing mouse cursor during middle-click autoscroll. Cursor updates were suppressed in EventHandler, but this doesn't work for plugins which call SetCursorForPlugin directly on ChromeClient. This was a preexisting bug, but it got worse with the recent rewrite because the bug used to be mostly covered up by the old implementation pushing cursor updates at 60fps. BUG=735865 Review-Url: https://codereview.chromium.org/2961003002 Cr-Commit-Position: refs/heads/master@{#483259} Committed: https://chromium.googlesource.com/chromium/src/+/be5aadf1dfe860773906916f5832... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/be5aadf1dfe860773906916f5832... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
