Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2960953002: Add about:flags entry for Mac V2 sandbox. (Closed)

Created:
3 years, 5 months ago by Greg K
Modified:
3 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add about:flags entry for Mac V2 sandbox. Add an entry to about:flags to enable the Mac V2 sandbox feature. BUG=689306 Review-Url: https://codereview.chromium.org/2960953002 Cr-Commit-Position: refs/heads/master@{#483146} Committed: https://chromium.googlesource.com/chromium/src/+/7e4f7a7f8665855aac32d51897608e12fdc1dc9d

Patch Set 1 #

Patch Set 2 : Fix enum order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Greg K
PTAL. Thanks, Greg
3 years, 5 months ago (2017-06-27 23:54:50 UTC) #3
Robert Sesek
LGTM
3 years, 5 months ago (2017-06-28 14:52:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960953002/1
3 years, 5 months ago (2017-06-28 17:17:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/488264)
3 years, 5 months ago (2017-06-28 18:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960953002/20001
3 years, 5 months ago (2017-06-28 21:21:55 UTC) #21
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 21:28:49 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e4f7a7f8665855aac32d5189760...

Powered by Google App Engine
This is Rietveld 408576698