[MD settings] change single line row height

[MD settings] change single line row height

This CL changes the height of single line UI rows from 45px to 48px as
requested by bettes@ (UX designer).

BUG=736953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2960803002
Cr-Commit-Position: refs/heads/master@{#482760}
Committed: https://chromium.googlesource.com/chromium/src/+/522d72aec37a711f65b180102cc42f99496fbb8a

[dschuyler, 2017-06-27 01:07:31]

Description was changed from

==========
[MD settings] change single line row height

This CL changes the height of single line UI rows from 45px to 48px as
requested by bettes@ (UX designer).

BUG=736953
==========

to

==========
[MD settings] change single line row height

This CL changes the height of single line UI rows from 45px to 48px as
requested by bettes@ (UX designer).

BUG=736953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-06-27 01:07:33]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 01:07:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-27 01:09:21]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-06-27 01:19:32]

LGTM

https://codereview.chromium.org/2960803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2960803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:46:
--settings-box-min-height: 48px;
Nit: Does the following work?

--settings-box-min-height: var(--settings-row-min-height);

[commit-bot: I haz the power, 2017-06-27 02:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 02:19:56]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-06-27 21:47:04]

https://codereview.chromium.org/2960803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2960803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:46:
--settings-box-min-height: 48px;
On 2017/06/27 01:19:32, dpapad wrote:
> Nit: Does the following work?
> 
> --settings-box-min-height: var(--settings-row-min-height);

I'm going to look into combining lines 37 to 48 in a separate CL.

[dschuyler, 2017-06-27 21:47:07]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:47:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 21:51:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498600027956590, "parent_rev":
"d698cc2f6fb72308e7aff05766ba4381a99d09f1", "commit_rev":
"522d72aec37a711f65b180102cc42f99496fbb8a"}

[commit-bot: I haz the power, 2017-06-27 21:51:38]

Description was changed from

==========
[MD settings] change single line row height

This CL changes the height of single line UI rows from 45px to 48px as
requested by bettes@ (UX designer).

BUG=736953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change single line row height

This CL changes the height of single line UI rows from 45px to 48px as
requested by bettes@ (UX designer).

BUG=736953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2960803002
Cr-Commit-Position: refs/heads/master@{#482760}
Committed:
https://chromium.googlesource.com/chromium/src/+/522d72aec37a711f65b180102cc4...
==========

[commit-bot: I haz the power, 2017-06-27 21:51:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/522d72aec37a711f65b180102cc4...