Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2960733004: Implement DocumentTimeline constructor (Closed)

Created:
3 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DocumentTimeline constructor This patch adds a constructor to DocumentTimeline to match the spec at http://w3c.github.io/web-animations/#the-documenttimeline-interface. The constructor enables the zero time of the timeline to be set at something other than the navigationStart moment. Changing the playback rate of the timeline (a functionality provided for DevTools support) still modifies this zero time. The initial value for the zero time is saved in the origin_time_ member. BUG=674514, 624639, 600248 Review-Url: https://codereview.chromium.org/2960733004 Cr-Commit-Position: refs/heads/master@{#483594} Committed: https://chromium.googlesource.com/chromium/src/+/7ee5b6192d46b7a25c3670c1aa8b10547e1057ef

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename in response to review #

Patch Set 3 : Extend rename into test file #

Patch Set 4 : Rebase #

Messages

Total messages: 29 (17 generated)
suzyh_UTC10 (ex-contributor)
3 years, 5 months ago (2017-06-28 23:31:06 UTC) #7
Eric Willigers
lgtm
3 years, 5 months ago (2017-06-29 00:31:38 UTC) #8
alancutter (OOO until 2018)
lgtm with nit. https://codereview.chromium.org/2960733004/diff/1/third_party/WebKit/Source/core/animation/DocumentTimeline.h File third_party/WebKit/Source/core/animation/DocumentTimeline.h (right): https://codereview.chromium.org/2960733004/diff/1/third_party/WebKit/Source/core/animation/DocumentTimeline.h#newcode71 third_party/WebKit/Source/core/animation/DocumentTimeline.h:71: double origin_time = 0.0, Let's use ...
3 years, 5 months ago (2017-06-29 03:16:19 UTC) #10
alancutter (OOO until 2018)
On 2017/06/29 at 03:16:19, alancutter wrote: > lgtm with nit. > > https://codereview.chromium.org/2960733004/diff/1/third_party/WebKit/Source/core/animation/DocumentTimeline.h > File ...
3 years, 5 months ago (2017-06-29 03:29:00 UTC) #11
suzyh_UTC10 (ex-contributor)
On 2017/06/29 at 03:29:00, alancutter wrote: > On 2017/06/29 at 03:16:19, alancutter wrote: > > ...
3 years, 5 months ago (2017-06-29 04:12:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960733004/40001
3 years, 5 months ago (2017-06-29 04:13:02 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/478927)
3 years, 5 months ago (2017-06-29 06:16:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960733004/40001
3 years, 5 months ago (2017-06-29 06:59:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960733004/60001
3 years, 5 months ago (2017-06-29 08:44:47 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/458793)
3 years, 5 months ago (2017-06-29 09:01:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960733004/60001
3 years, 5 months ago (2017-06-29 23:25:52 UTC) #26
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 02:20:05 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7ee5b6192d46b7a25c3670c1aa8b...

Powered by Google App Engine
This is Rietveld 408576698