Handle super-method call

pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
index 137c63782d6790664f202aa0580fda3ecec099f1..cf33142a6236998d4e05412585019832280814e0 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
@@ -138,11 +138,10 @@ jsAst.Statement buildSetupProgram(
     'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),
     'hasRetainedMetadata': backend.mirrorsData.hasRetainedMetadata,
     'types': typesAccess,
-    'objectClassName': js.quoteName(namer.runtimeTypeName(
-        // ignore: UNNECESSARY_CAST

[Siggi Cherem (dart-lang), 2017/06/27 20:12:57]

I thought this was needed to keep the code strong clean?

[Johnni Winther, 2017/06/28 08:03:03]

runtimeTypeName has since changed to take an Entity.

-        closedWorld.commonElements.objectClass as Entity)),
+    'objectClassName': js.quoteName(
+        namer.runtimeTypeName(closedWorld.commonElements.objectClass)),
     'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,
-    'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null ||

[Johnni Winther, 2017/06/28 08:03:03]

This was `true` after adding super-calls.... that's how they were related. Not
sure why.

[Siggi Cherem (dart-lang), 2017/06/28 15:57:02]

super-calls are pulling in mirrors? This actually concerns me.

When super cannot be resolved, the front_end may generate a noSuchMethod calls
that creates an InvocationMirror, could it be from something like that?

[Johnni Winther, 2017/06/30 08:18:46]

Add super-methods sets `needsStructuredMemberInfo` to true in
'container_builder.dart' which in turn adds the 'addStubs' method in the
generated code, which includes the 'usesMangledNames' value.

So super doesn't trigger mirrors but the ability to see whether mirrors is used.

[Siggi Cherem (dart-lang), 2017/06/30 17:34:24]

I see - thanks for clarifying.

+    'usesMangledNames': closedWorld.backendUsage.isMirrorsUsed ||
         closedWorld.backendUsage.isFunctionApplyUsed,
     'tearOffCode': buildTearOffCode(
         compiler.options, emitter, namer, closedWorld.commonElements),