Handle super-method call

pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter.full_emitter;
 
 // TODO(ahe): Share these with js_helper.dart.
 const FUNCTION_INDEX = 0;
 const NAME_INDEX = 1;
 const CALL_NAME_INDEX = 2;
@@ skipping 120 matching lines @@
     'needsNativeSupport': program.needsNativeSupport,
     'enabledJsInterop': backend.nativeBasicData.isJsInteropUsed,
     'jsInteropBoostrap': backend.jsInteropAnalysis.buildJsInteropBootstrap(),
     'isInterceptorClass':
         namer.operatorIs(closedWorld.commonElements.jsInterceptorClass),
     'isObject': namer.operatorIs(closedWorld.commonElements.objectClass),
     'specProperty': js.string(namer.nativeSpecProperty),
     'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),
     'hasRetainedMetadata': backend.mirrorsData.hasRetainedMetadata,
     'types': typesAccess,
-    'objectClassName': js.quoteName(namer.runtimeTypeName(
-        // ignore: UNNECESSARY_CAST

[Siggi Cherem (dart-lang), 2017/06/27 20:12:57]

I thought this was needed to keep the code strong clean?

[Johnni Winther, 2017/06/28 08:03:03]

runtimeTypeName has since changed to take an Entity.

-        closedWorld.commonElements.objectClass as Entity)),
+    'objectClassName': js.quoteName(
+        namer.runtimeTypeName(closedWorld.commonElements.objectClass)),
     'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,
-    'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null ||

[Johnni Winther, 2017/06/28 08:03:03]

This was `true` after adding super-calls.... that's how they were related. Not
sure why.

[Siggi Cherem (dart-lang), 2017/06/28 15:57:02]

super-calls are pulling in mirrors? This actually concerns me.

When super cannot be resolved, the front_end may generate a noSuchMethod calls
that creates an InvocationMirror, could it be from something like that?

[Johnni Winther, 2017/06/30 08:18:46]

Add super-methods sets `needsStructuredMemberInfo` to true in
'container_builder.dart' which in turn adds the 'addStubs' method in the
generated code, which includes the 'usesMangledNames' value.

So super doesn't trigger mirrors but the ability to see whether mirrors is used.

[Siggi Cherem (dart-lang), 2017/06/30 17:34:24]

I see - thanks for clarifying.

+    'usesMangledNames': closedWorld.backendUsage.isMirrorsUsed ||
         closedWorld.backendUsage.isFunctionApplyUsed,
     'tearOffCode': buildTearOffCode(
         compiler.options, emitter, namer, closedWorld.commonElements),
     'nativeInfoHandler': nativeInfoHandler,
     'operatorIsPrefix': js.string(namer.operatorIsPrefix),
     'deferredActionString': js.string(namer.deferredAction)
   };
   String skeleton = '''
 function $setupProgramName(programData, typesOffset) {
   "use strict";
@@ skipping 693 matching lines @@
 (function() {
   var result = $array[$index];
   if ($check) {
     throw new Error(
         name + ": expected value of type \'$type\' at index " + ($index) +
         " but got " + (typeof result));
   }
   return result;
 })()''';
 }