Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2960723004: Handle super-method call (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle super-method call + add BackendUsage.isMirrorUsed (yes, these were related!) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4d26bc56b4f9e304cbd11f62d59c39633e748478

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 6 chunks +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 2 chunks +13 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mirror_private_name_inheritance_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-27 09:37:14 UTC) #2
Siggi Cherem (dart-lang)
related!? how!? because of the last test? lgtm, w/comment below about strong-clean check https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart File ...
3 years, 5 months ago (2017-06-27 20:12:57 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 4d26bc56b4f9e304cbd11f62d59c39633e748478 (presubmit successful).
3 years, 5 months ago (2017-06-28 08:02:08 UTC) #5
Johnni Winther
https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right): https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart#newcode1956 pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1956: // of checking `mirrorsLibrary`. On 2017/06/27 20:12:57, Siggi Cherem ...
3 years, 5 months ago (2017-06-28 08:03:03 UTC) #6
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart File pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart (left): https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart#oldcode145 pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart:145: 'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null || On 2017/06/28 08:03:03, Johnni ...
3 years, 5 months ago (2017-06-28 15:57:02 UTC) #7
Siggi Cherem (dart-lang)
friendly ping on the question below
3 years, 5 months ago (2017-06-30 03:15:07 UTC) #8
Johnni Winther
https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart File pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart (left): https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart#oldcode145 pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart:145: 'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null || On 2017/06/28 15:57:02, Siggi ...
3 years, 5 months ago (2017-06-30 08:18:46 UTC) #9
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-06-30 17:34:24 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
(left):

https://codereview.chromium.org/2960723004/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart:145:
'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null ||
On 2017/06/30 08:18:46, Johnni Winther wrote:
> On 2017/06/28 15:57:02, Siggi Cherem (dart-lang) wrote:
> > On 2017/06/28 08:03:03, Johnni Winther wrote:
> > > This was `true` after adding super-calls.... that's how they were related.
> Not
> > > sure why.
> > 
> > super-calls are pulling in mirrors? This actually concerns me.
> > 
> > When super cannot be resolved, the front_end may generate a noSuchMethod
calls
> > that creates an InvocationMirror, could it be from something like that?
> 
> Add super-methods sets `needsStructuredMemberInfo` to true in
> 'container_builder.dart' which in turn adds the 'addStubs' method in the
> generated code, which includes the 'usesMangledNames' value.
> 
> So super doesn't trigger mirrors but the ability to see whether mirrors is
used.

I see - thanks for clarifying.

Powered by Google App Engine
This is Rietveld 408576698