Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2960713002: Restore calls to set cert fetcher on some platforms. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
mattm
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore calls to set cert fetcher on some platforms. https://codereview.chromium.org/2929153002 accidentally removed the calls when it switch URLRequestContext creation over to using URLRequestContextBuilder. Since no tests rely on these two calls, the breakage was not caught by tests. BUG=736859 Review-Url: https://codereview.chromium.org/2960713002 Cr-Commit-Position: refs/heads/master@{#482428} Committed: https://chromium.googlesource.com/chromium/src/+/4dcfb51eaa0aa79a8f92b6e0db1486cee1119fcd

Patch Set 1 #

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -29 lines) Patch
M chrome/browser/io_thread.cc View 1 3 chunks +18 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
mmenke
3 years, 5 months ago (2017-06-26 20:46:47 UTC) #6
mattm
lgtm
3 years, 5 months ago (2017-06-26 21:56:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960713002/20001
3 years, 5 months ago (2017-06-26 21:56:44 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 22:00:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4dcfb51eaa0aa79a8f92b6e0db14...

Powered by Google App Engine
This is Rietveld 408576698