Replace StreamListenSocket with StreamSocket in HttpServer.

net/socket/tcp_server_socket.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_TCP_SERVER_SOCKET_H_
 #define NET_SOCKET_TCP_SERVER_SOCKET_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_export.h"
 #include "net/base/net_log.h"
+#include "net/base/net_util.h"

[mmenke, 2014/05/23 19:20:58]

What is this needed for?

[byungchul, 2014/05/30 00:19:02]

Done.

 #include "net/socket/server_socket.h"
 #include "net/socket/tcp_socket.h"
 
 namespace net {
 
 class NET_EXPORT_PRIVATE TCPServerSocket : public ServerSocket {
  public:
   TCPServerSocket(NetLog* net_log, const NetLog::Source& source);
   virtual ~TCPServerSocket();
 
   // net::ServerSocket implementation.
   virtual int Listen(const IPEndPoint& address, int backlog) OVERRIDE;
   virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
   virtual int Accept(scoped_ptr<StreamSocket>* socket,
                      const CompletionCallback& callback) OVERRIDE;
 
+  // Factory with IP address string and port.
+  static scoped_ptr<TCPServerSocket> Create(const std::string& ip, int port);

[mmenke, 2014/05/23 19:20:58]

I think it's kinda of weird to have TCPServerSocket() and Listen() combined, but
only when using this special alternative function, which takes in address in a
different format.

If it's worth adding a convenience function that takes the ip as a string, I
think it should be added as an alternative Listen function, to ServerSocket. 
The implementation should also be in ServerSocket, since it just calls into
Listen.

You should also modify existing callers that could benefit from the function to
use it (See extensions/browser/api/socket/tcp_socket.cc).

[byungchul, 2014/05/30 00:19:02]

Defined ServerSocketFactory which is necessary to store ip/port info and
create/listen later for devtools.

Added TODO for tcp_socket.cc.

+
  private:
   // Converts |accepted_socket_| and stores the result in
   // |output_accepted_socket|.
   // |output_accepted_socket| is untouched on failure. But |accepted_socket_| is
   // set to NULL in any case.
   int ConvertAcceptedSocket(int result,
                             scoped_ptr<StreamSocket>* output_accepted_socket);
   // Completion callback for calling TCPSocket::Accept().
   void OnAcceptCompleted(scoped_ptr<StreamSocket>* output_accepted_socket,
                          const CompletionCallback& forward_callback,
                          int result);
 
   TCPSocket socket_;
 
   scoped_ptr<TCPSocket> accepted_socket_;
   IPEndPoint accepted_address_;
   bool pending_accept_;
 
   DISALLOW_COPY_AND_ASSIGN(TCPServerSocket);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_TCP_SERVER_SOCKET_H_