Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2960523002:
[Extensions Bindings] Don't load sendRequest module with native bindings (Closed)
Description[Extensions Bindings] Don't load sendRequest module with native bindings
Sending an extension request is implemented natively with native
bindings, and the JS version should never be used. Don't load the
sendRequest module when native bindings are enabled to enforce this.
BUG=653596
Review-Url: https://codereview.chromium.org/2960523002
Cr-Commit-Position: refs/heads/master@{#483074}
Committed: https://chromium.googlesource.com/chromium/src/+/6a96b1c50789ce0f63946137b7c8f1a223699add
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : remove debug log #
Messages
Total messages: 23 (18 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== blacklist sendRequest with native bindings BUG= ========== to ========== [Extensions Bindings] Don't load sendRequest module with native bindings Sending an extension request is implemented natively with native bindings, and the JS version should never be used. Don't load the sendRequest module when native bindings are enabled to enforce this. BUG=653596 ==========
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
lazyboy@, mind taking a look? jbroman@, FYI.
lgtm https://codereview.chromium.org/2960523002/diff/20001/extensions/renderer/mod... File extensions/renderer/module_system.cc (right): https://codereview.chromium.org/2960523002/diff/20001/extensions/renderer/mod... extensions/renderer/module_system.cc:700: LOG(WARNING) << "Module: " << module_name; Remove this debug logs.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2960523002/diff/20001/extensions/renderer/mod... File extensions/renderer/module_system.cc (right): https://codereview.chromium.org/2960523002/diff/20001/extensions/renderer/mod... extensions/renderer/module_system.cc:700: LOG(WARNING) << "Module: " << module_name; On 2017/06/27 17:47:22, lazyboy wrote: > Remove this debug logs. Whoops! Thought I did that. Done.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2960523002/#ps40001 (title: "remove debug log")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498674354116850,
"parent_rev": "abade4578be9f49dee1fdfe1a80ccdaa3ca3f386", "commit_rev":
"6a96b1c50789ce0f63946137b7c8f1a223699add"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions Bindings] Don't load sendRequest module with native bindings Sending an extension request is implemented natively with native bindings, and the JS version should never be used. Don't load the sendRequest module when native bindings are enabled to enforce this. BUG=653596 ========== to ========== [Extensions Bindings] Don't load sendRequest module with native bindings Sending an extension request is implemented natively with native bindings, and the JS version should never be used. Don't load the sendRequest module when native bindings are enabled to enforce this. BUG=653596 Review-Url: https://codereview.chromium.org/2960523002 Cr-Commit-Position: refs/heads/master@{#483074} Committed: https://chromium.googlesource.com/chromium/src/+/6a96b1c50789ce0f63946137b7c8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6a96b1c50789ce0f63946137b7c8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
