Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2960493003: VR: Properly space multiple system indicators across the screen. (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 5 months ago
Reviewers:
asimjour1, mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Properly space multiple system indicators across the screen. A math error meant that elements were not quite centered. BUG= Review-Url: https://codereview.chromium.org/2960493003 Cr-Commit-Position: refs/heads/master@{#482093} Committed: https://chromium.googlesource.com/chromium/src/+/1f547f2e280b4cb80921832f94b7ccd1cceec760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
cjgrant
3 years, 6 months ago (2017-06-23 23:40:21 UTC) #2
mthiesse
lgtm
3 years, 6 months ago (2017-06-23 23:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960493003/1
3 years, 6 months ago (2017-06-23 23:57:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1f547f2e280b4cb80921832f94b7ccd1cceec760
3 years, 6 months ago (2017-06-24 00:46:38 UTC) #8
asimjour1
3 years, 5 months ago (2017-06-26 15:50:23 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698