SavedFilesServiceInterface in //extensions

SavedFilesServiceInterface in //extensions

apps::SavedFilesService provides apps with a LRU queue of "retained"
file entries they are allowed access to. See chrome.fileSystem API docs:
https://developer.chrome.com/apps/fileSystem#method-retainEntry

Chrome extension APIs can already use the service in //apps, but APIs
implemented in //extensions cannot (they can't depend on //apps). This
change enables moving chrome.fileSystem into //extensions.

This CL makes apps::SavedFilesService derive from a new interface,
extensions::SavedFilesServiceInterface. The new interface took a few
methods from the original Service.

BUG=729713
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2960433002
Cr-Commit-Position: refs/heads/master@{#482297}
Committed: https://chromium.googlesource.com/chromium/src/+/868a94beaaa07d23125c241ef9f83ba4fa330fb8

[michaelpg, 2017-06-23 20:45:44]

Description was changed from

==========
SavedFilesServiceInterface in //extensions

apps::SavedFilesService provides apps with a LRU queue of "retained"
file entries they are allowed access to. See chrome.fileSystem API docs:
https://developer.chrome.com/apps/fileSystem#method-retainEntry

Chrome extension APIs can already use the service in //apps, but APIs
implemented in //extensions cannot (they can't depend on //apps). This
change enables moving chrome.fileSystem into //extensions.

This CL:

* Adds an extensions::SavedFilesServiceInterface, consisting of a few
  functions from apps::SavedFilesService
* Makes apps::SavedFilesService derive from
  extensions::SavedFilesServiceInterface
* Moves apps::SavedFileEntry struct into extensions::

BUG=729713
R=benwells@chromium.org
==========

to

==========
SavedFilesServiceInterface in //extensions

apps::SavedFilesService provides apps with a LRU queue of "retained"
file entries they are allowed access to. See chrome.fileSystem API docs:
https://developer.chrome.com/apps/fileSystem#method-retainEntry

Chrome extension APIs can already use the service in //apps, but APIs
implemented in //extensions cannot (they can't depend on //apps). This
change enables moving chrome.fileSystem into //extensions.

This CL makes apps::SavedFilesService derive from a new interface,
extensions::SavedFilesServiceInterface. The new interface took a few
methods from the original Service.

BUG=729713
R=benwells@chromium.org
==========

[michaelpg, 2017-06-23 20:45:49]

PTAL.

[benwells, 2017-06-26 02:17:53]

lgtm, thanks!

[michaelpg, 2017-06-26 15:28:51]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-06-26 15:28:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2960433002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-26 15:29:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 16:55:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498490931647120,
"parent_rev": "ef8473e89d8066184b4811f3cfa50656e91a224f", "commit_rev":
"868a94beaaa07d23125c241ef9f83ba4fa330fb8"}

[commit-bot: I haz the power, 2017-06-26 16:55:35]

Description was changed from

==========
SavedFilesServiceInterface in //extensions

apps::SavedFilesService provides apps with a LRU queue of "retained"
file entries they are allowed access to. See chrome.fileSystem API docs:
https://developer.chrome.com/apps/fileSystem#method-retainEntry

Chrome extension APIs can already use the service in //apps, but APIs
implemented in //extensions cannot (they can't depend on //apps). This
change enables moving chrome.fileSystem into //extensions.

This CL makes apps::SavedFilesService derive from a new interface,
extensions::SavedFilesServiceInterface. The new interface took a few
methods from the original Service.

BUG=729713
R=benwells@chromium.org
==========

to

==========
SavedFilesServiceInterface in //extensions

apps::SavedFilesService provides apps with a LRU queue of "retained"
file entries they are allowed access to. See chrome.fileSystem API docs:
https://developer.chrome.com/apps/fileSystem#method-retainEntry

Chrome extension APIs can already use the service in //apps, but APIs
implemented in //extensions cannot (they can't depend on //apps). This
change enables moving chrome.fileSystem into //extensions.

This CL makes apps::SavedFilesService derive from a new interface,
extensions::SavedFilesServiceInterface. The new interface took a few
methods from the original Service.

BUG=729713
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2960433002
Cr-Commit-Position: refs/heads/master@{#482297}
Committed:
https://chromium.googlesource.com/chromium/src/+/868a94beaaa07d23125c241ef9f8...
==========

[commit-bot: I haz the power, 2017-06-26 16:55:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/868a94beaaa07d23125c241ef9f8...