Issue 296043014: Cleanup: Do not pass a non-const ref in RequestDesktopNotificationPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296043014: Cleanup: Do not pass a non-const ref in RequestDesktopNotificationPermission. (Closed)

Created:
6 years, 7 months ago by Lei Zhang

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, nasko

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup: Do not pass a non-const ref in RequestDesktopNotificationPermission. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272670

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/296043014/1

6 years, 7 months ago (2014-05-23 21:16:06 UTC) #4

Message was sent while issue was closed.

Change committed as 272670