Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 296043014: Cleanup: Do not pass a non-const ref in RequestDesktopNotificationPermission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 444
445 // Returns a class to get notifications about media event. The embedder can 445 // Returns a class to get notifications about media event. The embedder can
446 // return NULL if they're not interested. 446 // return NULL if they're not interested.
447 virtual MediaObserver* GetMediaObserver(); 447 virtual MediaObserver* GetMediaObserver();
448 448
449 // Asks permission to show desktop notifications. |callback| needs to be run 449 // Asks permission to show desktop notifications. |callback| needs to be run
450 // when the user approves the request. 450 // when the user approves the request.
451 virtual void RequestDesktopNotificationPermission( 451 virtual void RequestDesktopNotificationPermission(
452 const GURL& source_origin, 452 const GURL& source_origin,
453 RenderFrameHost* render_frame_host, 453 RenderFrameHost* render_frame_host,
454 base::Closure& callback) {} 454 const base::Closure& callback) {}
455 455
456 // Checks if the given page has permission to show desktop notifications. 456 // Checks if the given page has permission to show desktop notifications.
457 // This is called on the IO thread. 457 // This is called on the IO thread.
458 virtual blink::WebNotificationPresenter::Permission 458 virtual blink::WebNotificationPresenter::Permission
459 CheckDesktopNotificationPermission( 459 CheckDesktopNotificationPermission(
460 const GURL& source_url, 460 const GURL& source_url,
461 ResourceContext* context, 461 ResourceContext* context,
462 int render_process_id); 462 int render_process_id);
463 463
464 // Show a desktop notification. If |cancel_callback| is non-null, it's set to 464 // Show a desktop notification. If |cancel_callback| is non-null, it's set to
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 // Allows an embedder to provide its own ExternalVideoSurfaceContainer 642 // Allows an embedder to provide its own ExternalVideoSurfaceContainer
643 // implementation. Return NULL to disable external surface video. 643 // implementation. Return NULL to disable external surface video.
644 virtual ExternalVideoSurfaceContainer* 644 virtual ExternalVideoSurfaceContainer*
645 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents); 645 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
646 #endif 646 #endif
647 }; 647 };
648 648
649 } // namespace content 649 } // namespace content
650 650
651 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 651 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698