Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2960353002:
DevTools: color swatch sliders should be positioned from left (Closed)
|
Created:
3 years, 5 months ago by luoe Modified:
3 years, 5 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: color swatch sliders should be positioned from left
When the color swatch's sliders were positioned from the right, it was possible
for them to overlap with other elements when the popover shrinks.
BUG=734548
Review-Url: https://codereview.chromium.org/2960353002
Cr-Commit-Position: refs/heads/master@{#483445}
Committed: https://chromium.googlesource.com/chromium/src/+/4879d9b4e22b2005ad222629991381801cc64cec
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== DevTools: color swatch sliders should be positioned from left BUG=734548 ========== to ========== DevTools: color swatch sliders should be positioned from left When the color swatch's sliders were positioned from the right, it was possible for them to overlap with other elements when the popover shrinks. BUG=734548 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
Please take a look
lgtm
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498757708582360, "parent_rev":
"94633b6531d7862439c21a361d605eb6a7c7db63", "commit_rev":
"c9cfe6e1b8b96b65bdee33b6b87a876045ee5162"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498757708582360, "parent_rev":
"da9529e35a5c7add99d5bf8b292eedc101ce1f42", "commit_rev":
"ea410c363833bb5d9f69eb59f32e5dfb460635fb"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498757708582360, "parent_rev":
"9708957ee9a7a53992e7e05caf7ef3a5ae2085bf", "commit_rev":
"4879d9b4e22b2005ad222629991381801cc64cec"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: color swatch sliders should be positioned from left When the color swatch's sliders were positioned from the right, it was possible for them to overlap with other elements when the popover shrinks. BUG=734548 ========== to ========== DevTools: color swatch sliders should be positioned from left When the color swatch's sliders were positioned from the right, it was possible for them to overlap with other elements when the popover shrinks. BUG=734548 Review-Url: https://codereview.chromium.org/2960353002 Cr-Commit-Position: refs/heads/master@{#483445} Committed: https://chromium.googlesource.com/chromium/src/+/4879d9b4e22b2005ad2226299913... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4879d9b4e22b2005ad2226299913... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
