Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2960293002: MD Extensions: Convert classes to use ES6 class syntax. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
Devlin
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Extensions: Convert classes to use ES6 class syntax. ES6 classes are now allowed in the JS styleguide. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2960293002 Cr-Commit-Position: refs/heads/master@{#484359} Committed: https://chromium.googlesource.com/chromium/src/+/5bf60281e3ba01737805ba8b505aa0731cce8ea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -108 lines) Patch
M chrome/browser/resources/md_extensions/animation_helper.js View 3 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/resources/md_extensions/manager.js View 2 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_extensions/navigation_helper.js View 3 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/resources/md_extensions/service.js View 11 chunks +63 lines, -60 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dpapad
ES6 classes are now allowed in our styleguide, see https://chromium.googlesource.com/chromium/src/+/master/docs/es6_chromium.md#Classes. Changing this mostly to start ...
3 years, 5 months ago (2017-06-28 23:20:34 UTC) #7
Devlin
lgtm!
3 years, 5 months ago (2017-07-05 15:54:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960293002/1
3 years, 5 months ago (2017-07-05 17:40:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/421130)
3 years, 5 months ago (2017-07-05 18:57:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960293002/1
3 years, 5 months ago (2017-07-05 21:02:06 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 21:51:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bf60281e3ba01737805ba8b505a...

Powered by Google App Engine
This is Rietveld 408576698