Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2960283002: Fix touch typing (Closed)

Created:
3 years, 5 months ago by David Tseng
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, aleventhal+watch_chromium.org, je_julie, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix touch typing Focus can remain on the address bar while ChromeVox range is over the keyboard. When typing occurs, text changes occur in the text field. We should output these events. This should be the only case where ChromeVox responds to text change events that are not in its current range. BUG=734816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2960283002 Cr-Commit-Position: refs/heads/master@{#483233} Committed: https://chromium.googlesource.com/chromium/src/+/84236eb3f0122c8c120d034d9e691be60d1de413

Patch Set 1 #

Patch Set 2 : Updates after offline discussion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
David Tseng
3 years, 5 months ago (2017-06-28 20:25:28 UTC) #3
dmazzoni
lgtm
3 years, 5 months ago (2017-06-28 21:29:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960283002/1
3 years, 5 months ago (2017-06-28 22:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960283002/20001
3 years, 5 months ago (2017-06-28 22:42:43 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 00:51:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84236eb3f0122c8c120d034d9e69...

Powered by Google App Engine
This is Rietveld 408576698