[fsp] Introduce chrome://fsp-internals for logging and debugging.

[fsp] Introduce chrome://fsp-internals for logging and debugging.

Similarly to chrome://drive-internals, this patch introduce a webui page
showing what's going on in the system.

Currently, only mounted file systems, and number of active requests are shown,
however more is coming soon.

TEST=Tested manually by invoking chrome://fsp-internals with a running
     providing extension.
BUG=376095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272886

[mtomasz, 2014-05-22 07:49:26]

@nkostylev: PTAL at webui.
@hashimoto: PTAL at */file_system_provider/*.

Thanks.

[hashimoto, 2014-05-22 09:21:07]

chrome/browser/chromeos/file_system_provider/ lgtm

https://codereview.chromium.org/296003012/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/fsp_internals_ui.h (right):

https://codereview.chromium.org/296003012/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/fsp_internals_ui.h:12: // The WebUI controller
for chrome::fsp-internals, that is used for diagnosing
nit: "chrome://fsp-internals"?

[mtomasz, 2014-05-23 00:29:09]

https://codereview.chromium.org/296003012/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/fsp_internals_ui.h (right):

https://codereview.chromium.org/296003012/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/fsp_internals_ui.h:12: // The WebUI controller
for chrome::fsp-internals, that is used for diagnosing
On 2014/05/22 09:21:07, hashimoto wrote:
> nit: "chrome://fsp-internals"?

Done.

[mtomasz, 2014-05-23 11:35:32]

@nkostylev: Ping.

[Nikita (slow), 2014-05-23 15:33:52]

lgtm

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/fsp_internals.html (right):

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/fsp_internals.html:13:
href="chrome://fsp-internals/fsp_internals.css"></link>
nit: 4 spaces alignment

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc (right):

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc:48:
DISALLOW_COPY_AND_ASSIGN(FSPInternalsWebUIHandler);
nit: Insert one empty line.

[mtomasz, 2014-05-26 00:34:31]

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/fsp_internals.html (right):

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/fsp_internals.html:13:
href="chrome://fsp-internals/fsp_internals.css"></link>
On 2014/05/23 15:33:52, Nikita Kostylev wrote:
> nit: 4 spaces alignment

AFAIK we can align attributes.

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc (right):

https://codereview.chromium.org/296003012/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc:48:
DISALLOW_COPY_AND_ASSIGN(FSPInternalsWebUIHandler);
On 2014/05/23 15:33:52, Nikita Kostylev wrote:
> nit: Insert one empty line.

Done.

[mtomasz, 2014-05-26 00:35:03]

@jochen: PTAL at chrome/browser/browser_resources.grd. Thanks.

[Nikita (slow), 2014-05-26 04:17:56]

HTML style guide says 4 spaces alignment. Can you please point me where it
is allowed? If that's the case, this has been changed.
26 мая 2014 г. 4:34 пользователь <mtomasz@chromium.org> написал:

>
> https://codereview.chromium.org/296003012/diff/20001/
> chrome/browser/resources/chromeos/fsp_internals.html
> File chrome/browser/resources/chromeos/fsp_internals.html (right):
>
> https://codereview.chromium.org/296003012/diff/20001/
> chrome/browser/resources/chromeos/fsp_internals.html#newcode13
> chrome/browser/resources/chromeos/fsp_internals.html:13:
> href="chrome://fsp-internals/fsp_internals.css"></link>
> On 2014/05/23 15:33:52, Nikita Kostylev wrote:
>
>> nit: 4 spaces alignment
>>
>
> AFAIK we can align attributes.
>
> https://codereview.chromium.org/296003012/diff/20001/
> chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc
> File chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc (right):
>
> https://codereview.chromium.org/296003012/diff/20001/
> chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc#newcode48
> chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc:48:
> DISALLOW_COPY_AND_ASSIGN(FSPInternalsWebUIHandler);
> On 2014/05/23 15:33:52, Nikita Kostylev wrote:
>
>> nit: Insert one empty line.
>>
>
> Done.
>
> https://codereview.chromium.org/296003012/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mtomasz, 2014-05-26 05:58:59]

On 2014/05/26 04:17:56, Nikita Kostylev wrote:
> HTML style guide says 4 spaces alignment. Can you please point me where it
> is allowed? If that's the case, this has been changed.
> 26 мая 2014 г. 4:34 пользователь <mailto:mtomasz@chromium.org> написал:
> 
> >
> > https://codereview.chromium.org/296003012/diff/20001/
> > chrome/browser/resources/chromeos/fsp_internals.html
> > File chrome/browser/resources/chromeos/fsp_internals.html (right):
> >
> > https://codereview.chromium.org/296003012/diff/20001/
> > chrome/browser/resources/chromeos/fsp_internals.html#newcode13
> > chrome/browser/resources/chromeos/fsp_internals.html:13:
> > href="chrome://fsp-internals/fsp_internals.css"></link>
> > On 2014/05/23 15:33:52, Nikita Kostylev wrote:
> >
> >> nit: 4 spaces alignment
> >>
> >
> > AFAIK we can align attributes.
> >
> > https://codereview.chromium.org/296003012/diff/20001/
> > chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc
> > File chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc (right):
> >
> > https://codereview.chromium.org/296003012/diff/20001/
> > chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc#newcode48
> > chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc:48:
> > DISALLOW_COPY_AND_ASSIGN(FSPInternalsWebUIHandler);
> > On 2014/05/23 15:33:52, Nikita Kostylev wrote:
> >
> >> nit: Insert one empty line.
> >>
> >
> > Done.
> >
> > https://codereview.chromium.org/296003012/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

You're right. I just checked and in the Chromium's additional style guides it
says 4.
http://www.chromium.org/developers/web-development-style-guide

I'm susprised, since the main style guide says nothing about it:
https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml

also, I've been asked several times during code reviews to align arguments.

Anyway, fixed.

[jochen (gone - plz use gerrit), 2014-05-26 09:56:13]

grd lgtm

[mtomasz, 2014-05-26 13:19:39]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-05-26 13:20:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/296003012/60001

[commit-bot: I haz the power, 2014-05-26 23:54:02]

Change committed as 272886