Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/binary_size/PRESUBMIT.py

Issue 296003007: Added PRESUBMIT.py for binary_size tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@andrew_binary_size
Patch Set: Addressed review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/explain_binary_size_delta.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/PRESUBMIT.py
diff --git a/tools/linux/PRESUBMIT.py b/tools/binary_size/PRESUBMIT.py
similarity index 56%
copy from tools/linux/PRESUBMIT.py
copy to tools/binary_size/PRESUBMIT.py
index d4d8601f9e66eb06b9cb990478b47d542248f5f7..d5a159bae770a435560d4ca68a350e7d5ccb6c08 100644
--- a/tools/linux/PRESUBMIT.py
+++ b/tools/binary_size/PRESUBMIT.py
@@ -1,34 +1,21 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
+# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Top-level presubmit script for linux.
+"""binary_size presubmit script
-See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
-details on the presubmit API built into gcl.
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into gcl.
"""
-
def CommonChecks(input_api, output_api):
- import sys
- def join(*args):
- return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
-
output = []
- sys_path_backup = sys.path
- try:
- sys.path = [
- join('..', 'linux'),
- ] + sys.path
- output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
- finally:
- sys.path = sys_path_backup
-
+ output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
output.extend(
input_api.canned_checks.RunUnitTestsInDirectory(
input_api, output_api,
- input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'),
- whitelist=[r'.+_tests\.py$']))
+ input_api.PresubmitLocalPath(),
+ whitelist=[r'.+_unittest\.py$']))
if input_api.is_committing:
output.extend(input_api.canned_checks.PanProjectChecks(input_api,
« no previous file with comments | « no previous file | tools/binary_size/explain_binary_size_delta.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698