Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: tools/binary_size/PRESUBMIT.py

Issue 296003007: Added PRESUBMIT.py for binary_size tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@andrew_binary_size
Patch Set: Addressed review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/binary_size/explain_binary_size_delta.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for linux. 5 """binary_size presubmit script
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 details on the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
11
12 def CommonChecks(input_api, output_api): 11 def CommonChecks(input_api, output_api):
13 import sys
14 def join(*args):
15 return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
16
17 output = [] 12 output = []
18 sys_path_backup = sys.path 13 output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
19 try:
20 sys.path = [
21 join('..', 'linux'),
22 ] + sys.path
23 output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
24 finally:
25 sys.path = sys_path_backup
26
27 output.extend( 14 output.extend(
28 input_api.canned_checks.RunUnitTestsInDirectory( 15 input_api.canned_checks.RunUnitTestsInDirectory(
29 input_api, output_api, 16 input_api, output_api,
30 input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'), 17 input_api.PresubmitLocalPath(),
31 whitelist=[r'.+_tests\.py$'])) 18 whitelist=[r'.+_unittest\.py$']))
32 19
33 if input_api.is_committing: 20 if input_api.is_committing:
34 output.extend(input_api.canned_checks.PanProjectChecks(input_api, 21 output.extend(input_api.canned_checks.PanProjectChecks(input_api,
35 output_api, 22 output_api,
36 owners_check=False)) 23 owners_check=False))
37 return output 24 return output
38 25
39 26
40 def CheckChangeOnUpload(input_api, output_api): 27 def CheckChangeOnUpload(input_api, output_api):
41 return CommonChecks(input_api, output_api) 28 return CommonChecks(input_api, output_api)
42 29
43 30
44 def CheckChangeOnCommit(input_api, output_api): 31 def CheckChangeOnCommit(input_api, output_api):
45 return CommonChecks(input_api, output_api) 32 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | tools/binary_size/explain_binary_size_delta.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698