Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 296003003: First step at setroots (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

First step at setroots Still a work in progress, but some of the basics are there. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271761

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -102 lines) Patch
M mojo/mojo_services.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 3 chunks +14 lines, -0 lines 0 comments Download
D mojo/services/view_manager/type_converters.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/view_manager/type_converters.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 chunks +27 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 9 chunks +141 lines, -23 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 9 chunks +129 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 7 months ago (2014-05-20 15:30:24 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/296003003/diff/20001/mojo/services/view_manager/view_manager_connection.h File mojo/services/view_manager/view_manager_connection.h (right): https://codereview.chromium.org/296003003/diff/20001/mojo/services/view_manager/view_manager_connection.h#newcode119 mojo/services/view_manager/view_manager_connection.h:119: // for the client. The parent in set ...
6 years, 7 months ago (2014-05-20 16:13:32 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-20 17:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/296003003/40001
6 years, 7 months ago (2014-05-20 17:17:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 20:40:53 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:41:48 UTC) #6
Message was sent while issue was closed.
Change committed as 271761

Powered by Google App Engine
This is Rietveld 408576698