Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 296003003: First step at setroots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/mojo_services.gypi ('k') | mojo/services/view_manager/type_converters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 9ac6ea102a705195e9b13f267938ab8737246fa2..39748a1bd421adfd98f34c726900a8f38437cb11 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -39,6 +39,9 @@ interface IViewManager {
// . |parent| or |child| does not identify a valid node.
// . |child| is an ancestor of |parent|.
// . |child| is already a child of |parent|.
+ //
+ // This may result in a connection getting OnNodeDeleted(). See
+ // RemoveNodeFromParent for details.
AddNode(uint32 parent,
uint32 child,
uint32 server_change_id) => (bool success);
@@ -46,6 +49,12 @@ interface IViewManager {
// Removes a view from its current parent. See description above class for
// details of |change_id|. This fails if the node is not valid,
// |server_change_id| doesn't match, or the node already has no parent.
+ //
+ // Removing a node from a parent may result in OnNodeDeleted() being sent to
+ // other connections. For example, connection A has nodes 1 and 2, with 2 a
+ // child of 1. Connection B has a root 1. If 2 is removed from 1 then B gets
+ // OnNodeDeleted(). This is done as node 2 is effectively no longer visible to
+ // connection B.
RemoveNodeFromParent(uint32 node_id,
uint32 server_change_id) => (bool success);
@@ -72,6 +81,11 @@ interface IViewManager {
SetViewContents(uint32 view_id,
handle<shared_buffer> buffer,
uint32 buffer_size);
+
+ // Sets the ids of the roots for the specified connection.
+ // TODO(sky): this is temporary for testing. This needs to be conveyed at
+ // creation time of a new connection.
+ SetRoots(uint16 connection_id, uint32[] nodes) => (bool success);
};
// Changes to nodes/views are not sent to the connection that originated the
« no previous file with comments | « mojo/mojo_services.gypi ('k') | mojo/services/view_manager/type_converters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698