Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2960023003: [DevTools] Migrate inspector-protocol/emulation tests to new harness (Closed)

Created:
3 years, 5 months ago by dgozman
Modified:
3 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate inspector-protocol/emulation tests to new harness BUG=734762 Review-Url: https://codereview.chromium.org/2960023003 Cr-Commit-Position: refs/heads/master@{#483067} Committed: https://chromium.googlesource.com/chromium/src/+/a4b8c993abf3c08f3761dc41666aacc008460da6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -1281 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +18 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320.html View 1 chunk +0 lines, -34 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320.js View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-2x-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-320-only-viewport-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980.js View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-2x-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-980-only-viewport-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls.html View 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls.js View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls-expected.txt View 2 chunks +2 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw.js View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-2x-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-dw-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale.html View 1 chunk +0 lines, -42 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale.js View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-initial-scale-expected.txt View 2 chunks +7 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-insets-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none.js View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x.html View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x.js View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-2x-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-none-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-partial.html View 1 chunk +0 lines, -138 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-partial.js View 1 chunk +95 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-partial-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore.html View 1 chunk +0 lines, -63 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore.js View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-restore-expected.txt View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small.html View 1 chunk +0 lines, -38 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small.js View 1 chunk +17 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw.html View 1 chunk +0 lines, -38 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw.js View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-dw-expected.txt View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-small-expected.txt View 2 chunks +5 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-scale-not-persistant.html View 1 chunk +0 lines, -87 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-scale-not-persistant.js View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-scale-not-persistant-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/resources/device-emulation.html View 3 chunks +24 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/resources/device-emulation-test.js View 1 chunk +0 lines, -259 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/device-emulator.js View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/device-scale-not-persistant.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js View 2 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 5 months ago (2017-06-28 00:02:10 UTC) #2
lushnikov
lgtm
3 years, 5 months ago (2017-06-28 18:12:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960023003/1
3 years, 5 months ago (2017-06-28 18:17:46 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 18:22:59 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4b8c993abf3c08f3761dc41666a...

Powered by Google App Engine
This is Rietveld 408576698