Add comment warning about modifying landmines

Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

R=dpranke@chromium.org
BUG=736939
Review-Url: https://codereview.chromium.org/2960013002
Cr-Commit-Position: refs/heads/master@{#483579}
Committed: https://chromium.googlesource.com/chromium/src/+/a1ed2e02283cf828822dd24dd0e8f5e22767b4bc

[brucedawson, 2017-06-27 20:21:09]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 20:21:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-06-27 20:22:06]

Try again, adding to the right file. What do you think?

[commit-bot: I haz the power, 2017-06-27 21:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:42:14]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-06-30 00:01:19]

lgtm

[brucedawson, 2017-06-30 00:02:10]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-06-30 00:02:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 01:25:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498780930169120, "parent_rev":
"904b494651543370dfac88ca7424c84796bd2dd0", "commit_rev":
"a1ed2e02283cf828822dd24dd0e8f5e22767b4bc"}

[commit-bot: I haz the power, 2017-06-30 01:25:25]

Description was changed from

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

R=dpranke@chromium.org
BUG=736939
==========

to

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

R=dpranke@chromium.org
BUG=736939

Review-Url: https://codereview.chromium.org/2960013002
Cr-Commit-Position: refs/heads/master@{#483579}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1ed2e02283cf828822dd24dd0e8...
==========

[commit-bot: I haz the power, 2017-06-30 01:25:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1ed2e02283cf828822dd24dd0e8...

[(unused - use chromium), 2017-06-30 12:40:11]

thakis@google.com changed reviewers:
+ thakis@google.com

[(unused - use chromium), 2017-06-30 12:40:12]

https://codereview.chromium.org/2960013002/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/2960013002/diff/1/build/get_landmines.py#newc...
build/get_landmines.py:40: # usually less troublesome alternatives.
I think the problem was that they didn't see the existing comment because it's
kind of at the top of this function, while people add stuff at the bottom. I
think maybe just moving this comment towards the bottom might be useful.