Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2960003003: In non-strong mode, don't infer the type of for-in loop variables. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In non-strong mode, don't infer the type of for-in loop variables. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0efe02372bb30e2396e9f49e9c03ffff39f991d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/for_in_loop_promotion.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-28 19:22:23 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-28 19:24:04 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-28 19:43:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0efe02372bb30e2396e9f49e9c03ffff39f991d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698