Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2960003003: In non-strong mode, don't infer the type of for-in loop variables. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/testcases/inference/for_in_loop_promotion.dart.direct.expect » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index 84ceb23eefefc33a9a408f54d582d2d890b3f8c9..0e2a3449a75b71259d4f9bd428e5b7c4e939754d 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -736,7 +736,7 @@ class KernelForInStatement extends ForInStatement implements KernelStatement {
KernelVariableDeclaration variable;
if (_declaresVariable) {
variable = this.variable;
- if (variable._implicitlyTyped) {
+ if (inferrer.strongMode && variable._implicitlyTyped) {
typeNeeded = true;
// TODO(paulberry): In this case, should the context be `Iterable<?>`?
} else {
« no previous file with comments | « no previous file | pkg/front_end/testcases/inference/for_in_loop_promotion.dart.direct.expect » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698