Issue 2960: Enable safe browsing tests exercising VerifyMAC....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2960: Enable safe browsing tests exercising VerifyMAC.... (Closed)

Created:
12 years, 3 months ago by please use my chromium address

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Dean McNamee, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Enable safe browsing tests exercising VerifyMAC. I left a bunch of TODOs in my previous changeset, http://codereview.chromium.org/2891 (commited), because I couldn't resolve some linking issues. Now I found a solution (similar to one in src/net/SConscript) - reordering libs so that dependencies follow dependents. BUG=2335 (it's a general bug about building SConscript.unit_tests)

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -15 lines)			Patch
M	chrome/SConscript.unit_tests	View	2 chunks	+3 lines, -3 lines	1 comment	Download
M	chrome/browser/safe_browsing/protocol_parser_unittest.cc	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

12 years, 3 months ago (2008-09-18 12:47:53 UTC) #2

LGTM, will commit and fix the nit below.

http://codereview.chromium.org/2960/diff/1/4
File chrome/SConscript.unit_tests (right):

http://codereview.chromium.org/2960/diff/1/4#newcode35
Line 35: 'bzip2',  # bzip2 must come before base
I wouldn't do a column style comment like this.  Do a block style before the
LIBS = line.

Expand Messages | Collapse Messages