Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2891: Include chrome/SConscript.unit_tests in Linux build.... (Closed)

Created:
12 years, 3 months ago by please use my chromium address
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, tony, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Include chrome/SConscript.unit_tests in Linux build. Some minor fixes done to prevent compile failures when http://codereview.chromium.org/2418 gets commited. It first requires http://codereview.chromium.org/2890 to be applied (building chrome/browser/). BUG=2335

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -215 lines) Patch
M chrome/SConscript View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/SConscript.unit_tests View 1 2 1 chunk +183 lines, -152 lines 0 comments Download
M chrome/browser/net/dns_host_info_unittest.cc View 1 2 5 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/chunk_range_unittest.cc View 1 2 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 1 2 18 chunks +27 lines, -37 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/unit/run_all_unittests.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
please use my chromium address
Will probably need more reviewers, please check.
12 years, 3 months ago (2008-09-16 14:15:57 UTC) #1
Mark Mentovai
http://codereview.chromium.org/2891/diff/1/6 File chrome/browser/net/dns_host_info_unittest.cc (right): http://codereview.chromium.org/2891/diff/1/6#newcode11 Line 11: Why is the blank line here? http://codereview.chromium.org/2891/diff/1/4 File ...
12 years, 3 months ago (2008-09-16 14:32:37 UTC) #2
please use my chromium address
On 2008/09/16 14:32:37, Mark Mentovai wrote: > http://codereview.chromium.org/2891/diff/1/6 > File chrome/browser/net/dns_host_info_unittest.cc (right): > > http://codereview.chromium.org/2891/diff/1/6#newcode11 ...
12 years, 3 months ago (2008-09-16 16:04:53 UTC) #3
Mark Mentovai
LGTM with a few more changes and another pair of eyes on the SConscript. http://codereview.chromium.org/2891/diff/13/214 ...
12 years, 3 months ago (2008-09-16 17:41:58 UTC) #4
please use my chromium address
On 2008/09/16 17:41:58, Mark Mentovai wrote: > LGTM with a few more changes and another ...
12 years, 3 months ago (2008-09-16 18:20:32 UTC) #5
sgk
SCons lgtm
12 years, 3 months ago (2008-09-17 00:07:16 UTC) #6
tony
Testing this patch on windows and will commit soon...
12 years, 3 months ago (2008-09-17 17:55:05 UTC) #7
tony
12 years, 3 months ago (2008-09-17 18:16:31 UTC) #8
Committed as @r2319.  Thanks!

Powered by Google App Engine
This is Rietveld 408576698