Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2959903002: Revert of Implement dumb URLLoader{Factory} for ServiceWorker script loading (Closed)

Created:
3 years, 5 months ago by shimazu
Modified:
3 years, 5 months ago
Reviewers:
falken, kinuko, dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, wjmaclean, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, abarth-chromium, Aaron Boodman, kinuko+serviceworker, yzshen+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org, scottmg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement dumb URLLoader{Factory} for ServiceWorker script loading (patchset #4 id:60001 of https://codereview.chromium.org/2943463002/ ) Reason for revert: This patch depends on https://crrev.com/1ebf3cb which is being reverted. See also the bug: https://crbug.com/736649 Original issue's description: > Implement dumb URLLoader{Factory} for ServiceWorker script loading > > Currently it only proxies request/response to/from the network factory, > plus does necessary HttpResponseInfo passing. > > The plan is to use this URLLoader for script loading/caching during > installation. (Currently this always sets-up the URLLoader{Factory} > if servicification is enabled because we need it for correctly setting > HttpResponseInfo of the main resource of ServiceWorker) > > (Patch on top of https://codereview.chromium.org/2779763004/ > Try: https://codereview.chromium.org/2936623002/) > > BUG=715640 > > Review-Url: https://codereview.chromium.org/2943463002 > Cr-Commit-Position: refs/heads/master@{#481477} > Committed: https://chromium.googlesource.com/chromium/src/+/e7ab19876d2a092ef09f584619ea82890e89050e TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=715640, 736649 Review-Url: https://codereview.chromium.org/2959903002 Cr-Commit-Position: refs/heads/master@{#482554} Committed: https://chromium.googlesource.com/chromium/src/+/751f0a2995bb1975449572a0b5328ec4db48b762

Patch Set 1 #

Patch Set 2 : pull master and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -257 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 6 chunks +0 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 3 chunks +2 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 5 chunks +6 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 6 chunks +0 lines, -165 lines 0 comments Download
M content/browser/service_worker/service_worker_url_loader_job.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_loader_job.cc View 1 2 chunks +3 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/service_worker/service_worker_provider.mojom View 1 3 chunks +1 line, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
shimazu
Created Revert of Implement dumb URLLoader{Factory} for ServiceWorker script loading
3 years, 5 months ago (2017-06-27 04:13:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959903002/1
3 years, 5 months ago (2017-06-27 04:13:23 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/240318) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-06-27 04:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959903002/310001
3 years, 5 months ago (2017-06-27 04:23:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/240322) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-06-27 04:25:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959903002/20002
3 years, 5 months ago (2017-06-27 04:33:15 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 06:54:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/751f0a2995bb1975449572a0b532...

Powered by Google App Engine
This is Rietveld 408576698