Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2959873002: color: Add NSScreenColorSpaceDidChangeNotification observer (Closed)

Created:
3 years, 5 months ago by ccameron
Modified:
3 years, 5 months ago
Reviewers:
hubbe
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Add NSScreenColorSpaceDidChangeNotification observer Change RenderWidgetHostViewMac to not query the display color profile directly, rather, use the display::Display screen information. This exposed a bug whereby we weren't updating the display::Display color space when NSScreens changed color spaces. Clean up RenderWidgetHostViewMac to make UpdateBackingStoreProperties call UpdateScreenInfo and update color space information, and change calls to UpdateScreenInfo to go through UpdateBackingStoreProperties appropriately. Also make BrowserCompositorMac query the current display scale factor and color space from the display::Display when activating. BUG=735613 Review-Url: https://codereview.chromium.org/2959873002 Cr-Commit-Position: refs/heads/master@{#482518} Committed: https://chromium.googlesource.com/chromium/src/+/942e74b0d721b0090cd4b30f8a31f04adf005fff

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -30 lines) Patch
M content/browser/renderer_host/browser_compositor_view_mac.mm View 2 chunks +9 lines, -5 lines 1 comment Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +7 lines, -22 lines 0 comments Download
M ui/display/mac/screen_mac.mm View 4 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ccameron
ptal -- more cleanup leaning more and more heavily on display::Display https://codereview.chromium.org/2959873002/diff/1/content/browser/renderer_host/browser_compositor_view_mac.mm File content/browser/renderer_host/browser_compositor_view_mac.mm (left): ...
3 years, 5 months ago (2017-06-26 22:45:02 UTC) #4
hubbe
This is a little outside my expertise, but I don't so anything actually wrong with ...
3 years, 5 months ago (2017-06-26 22:51:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959873002/1
3 years, 5 months ago (2017-06-27 02:23:57 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 02:27:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/942e74b0d721b0090cd4b30f8a31...

Powered by Google App Engine
This is Rietveld 408576698