Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2959853003: Add UI components for license type selection in ChromeOS login UI. (Closed)

Created:
3 years, 5 months ago by Denis Kuznetsov (DE-MUC)
Modified:
3 years, 5 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, bartfab (slow)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UI components for license type selection in ChromeOS login UI. Changes that would actually use them (enrollment screen) would come in next CL. BUG=725124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2959853003 Cr-Commit-Position: refs/heads/master@{#489529} Committed: https://chromium.googlesource.com/chromium/src/+/3d1e27d07f9eb13b298556a877d4b54bcb94ca33

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased to ToT #

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebase to ToT #

Patch Set 5 : Remove unused flex import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_view.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_status_chromeos.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_login.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_login.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/enrollment_license_card.css View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/enrollment_license_card.html View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/enrollment_license_card.js View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 2 3 7 chunks +50 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 2 3 6 chunks +29 lines, -0 lines 0 comments Download
M components/policy/core/common/cloud/enterprise_metrics.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (22 generated)
Denis Kuznetsov (DE-MUC)
bartfab: chrome/browser/chromeos/policy/enrollment_status_chromeos.h components/policy/core/common/cloud/enterprise_metrics.h alemate: chrome/browser/chromeos/login/enrollment/enrollment_screen.cc chrome/browser/chromeos/login/enrollment/enrollment_screen.h chrome/browser/chromeos/login/enrollment/enrollment_screen_view.h chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h chrome/browser/resources/chromeos/login/custom_elements_login.html chrome/browser/resources/chromeos/login/custom_elements_login.js chrome/browser/resources/chromeos/login/custom_elements_oobe.html chrome/browser/resources/chromeos/login/custom_elements_oobe.js chrome/browser/resources/chromeos/login/enrollment_license_card.css chrome/browser/resources/chromeos/login/enrollment_license_card.html ...
3 years, 5 months ago (2017-06-27 16:21:16 UTC) #3
Nikita (slow)
On 2017/06/27 16:21:16, Denis Kuznetsov (DE-MUC) wrote: > nkostylev: > chrome/browser/chromeos/login/enrollment/enrollment_screen.cc > chrome/browser/chromeos/login/enrollment/enrollment_screen.h > chrome/browser/chromeos/login/enrollment/enrollment_screen_view.h ...
3 years, 5 months ago (2017-06-27 17:35:03 UTC) #6
Alexander Alekseev
lgtm
3 years, 5 months ago (2017-07-06 09:36:01 UTC) #9
Denis Kuznetsov (DE-MUC)
+emaxx as a reviewer instead of bartfab
3 years, 5 months ago (2017-07-06 18:47:14 UTC) #11
emaxx
policy - lgtm with a nit
3 years, 5 months ago (2017-07-07 14:32:20 UTC) #12
emaxx
https://codereview.chromium.org/2959853003/diff/1/components/policy/core/common/cloud/enterprise_metrics.h File components/policy/core/common/cloud/enterprise_metrics.h (right): https://codereview.chromium.org/2959853003/diff/1/components/policy/core/common/cloud/enterprise_metrics.h#newcode233 components/policy/core/common/cloud/enterprise_metrics.h:233: kEnrollmentLicenseRequestFailed = 57, nit: s/kEnrollmentLicenseRequestFailed/kMetricEnrollmentLicenseRequestFailed/ (following the style of ...
3 years, 5 months ago (2017-07-07 14:32:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959853003/20001
3 years, 5 months ago (2017-07-13 18:44:01 UTC) #16
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/2959853003/diff/1/components/policy/core/common/cloud/enterprise_metrics.h File components/policy/core/common/cloud/enterprise_metrics.h (right): https://codereview.chromium.org/2959853003/diff/1/components/policy/core/common/cloud/enterprise_metrics.h#newcode233 components/policy/core/common/cloud/enterprise_metrics.h:233: kEnrollmentLicenseRequestFailed = 57, On 2017/07/07 14:32:34, emaxx wrote: > ...
3 years, 5 months ago (2017-07-13 18:44:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959853003/40001
3 years, 5 months ago (2017-07-13 18:47:08 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/337861)
3 years, 5 months ago (2017-07-13 20:58:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959853003/60001
3 years, 5 months ago (2017-07-25 19:00:33 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/476210)
3 years, 5 months ago (2017-07-25 20:42:27 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959853003/80001
3 years, 5 months ago (2017-07-25 22:44:05 UTC) #33
commit-bot: I haz the power
3 years, 5 months ago (2017-07-26 02:15:39 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3d1e27d07f9eb13b298556a877d4...

Powered by Google App Engine
This is Rietveld 408576698