config_service: add last import validation and tests

config_service: add last import validation and tests

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
Review-Url: https://codereview.chromium.org/2959833002
Committed: https://github.com/luci/luci-py/commit/56121b33d24c5a9fb2a8aff8247cf52f749a6952

[ayanaadylova, 2017-06-26 21:25:06]

Description was changed from

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Link to the staging version:
https://2920-5115504-tainted-ayanaadylova-dot-luci-config-dev.appspot.com/newui
Screenshots:

BUG=730832
==========

to

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Link to the staging version:
https://2920-5115504-tainted-ayanaadylova-dot-luci-config-dev.appspot.com/newui
Screenshots:
https://screenshot.googleplex.com/KTzSbPzqYcm
https://screenshot.googleplex.com/hnTJyTFRhwS

BUG=730832
==========

[ayanaadylova, 2017-06-26 21:28:57]

ayanaadylova@google.com changed reviewers:
+ hinoka@google.com, sergeyberezin@chromium.org

[ayanaadylova, 2017-06-26 21:28:58]

I am not sure why, but for config-set-card and config-set files diff shows that
I added all the lines, but I only changed some parts of these files.
PTAL

[Sergey Berezin, 2017-06-26 22:57:08]

On 2017/06/26 at 21:28:58, ayanaadylova wrote:
> I am not sure why, but for config-set-card and config-set files diff shows
that I added all the lines, but I only changed some parts of these files.
> PTAL

Weird... Is your branch based on the latest top-of-the-trunk? ('git pull' the
master branch before 'git new-branch', or 'git pull --rebase' in your current
branch and try uploading again).

[Sergey Berezin, 2017-06-26 23:16:26]

Overall seems good. For this CL, let's write some tests for the new
functionality. Thanks!

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/config-set-card.html (right):

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/config-set-card.html:53:
lastImportAttempt: {
nit: I'd name it lastImportAttemptSuccess, to be clear what the Boolean value
means.

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:30: //
TODO(ayanaadylova@): write tests for the config-set element.
Let's actually write the tests in this CL.

[ayanaadylova, 2017-06-26 23:56:58]

Description was changed from

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Link to the staging version:
https://2920-5115504-tainted-ayanaadylova-dot-luci-config-dev.appspot.com/newui
Screenshots:
https://screenshot.googleplex.com/KTzSbPzqYcm
https://screenshot.googleplex.com/hnTJyTFRhwS

BUG=730832
==========

to

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.

BUG=730832
==========

[ayanaadylova, 2017-06-26 23:57:11]

On 2017/06/26 21:28:58, ayanaadylova wrote:
> I am not sure why, but for config-set-card and config-set files diff shows
that
> I added all the lines, but I only changed some parts of these files.
> PTAL

Link to the staging version:
https://2920-5115504-tainted-ayanaadylova-dot-luci-config-dev.appspot.com/newui
Screenshots:
https://screenshot.googleplex.com/KTzSbPzqYcm
https://screenshot.googleplex.com/hnTJyTFRhwS

[ayanaadylova, 2017-06-28 15:37:28]

Added some tests for front-page and config-set page. 
I also have not yet figured out the problem with automated testing, but I posted
a question in the polymer discussion.
PTAL

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
File appengine/config_service/ui/src/config-ui/config-set-card.html (right):

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
appengine/config_service/ui/src/config-ui/config-set-card.html:53:
lastImportAttempt: {
On 2017/06/26 23:16:26, Sergey Berezin wrote:
> nit: I'd name it lastImportAttemptSuccess, to be clear what the Boolean value
> means.

Done.

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/40001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:30: //
TODO(ayanaadylova@): write tests for the config-set element.
On 2017/06/26 23:16:26, Sergey Berezin wrote:
> Let's actually write the tests in this CL.

Done.

[Sergey Berezin, 2017-06-28 19:11:36]

This is great progress! One more set of comments to polish up the tests. Thanks!

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/app.yaml (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/app.yaml:16: 
nit: Please remove the white spaces in the empty line.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:22:
<test-fixture id="projects/infra-experimental">
nit: we usually try to avoid having actual production names in tests. It's OK to
model your data based on the real one, but it's better to rename it to something
obviously fake. E.g. "projects/up-to-date-project" or
"projects/invalid-config-project".

Descriptive names like that also make the test more readable, as they suggest
what to expect in assertions.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:43: test('checks
the category of config set', function() {
nit: it's a good practice to name suites and tests so they sound like English
sentences. E.g.:
  "Up-to-date project config set"
     - has correct category
     - has correct  name
     - sets isLoading by default
     - displays valid last import attempt
etc.

Ideally, a test suite would also read like a "story" (there is even a term "test
story") - where a sequence of events leads to expected assertions at each point.


See https://youtu.be/_9qARcdCAn4?t=412 for another naming sample.

Having said that, this is not a hard requirement, only a guideline.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:68:
suite('<config-set>', function() {
Should the suite names be different?

The two test suites seem to be running roughly the same tests for different
config sets, which seems redundant.

Since your change is about detecting valid vs. invalid configs, it makes sense
to have tests for these two cases. I'd suggest to turn this second suite into
tests for an invalid config set.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:91:
assert.equal(config_set.files.length, 0);
nit: it would be interesting to generate a few files in a config set, here or in
another test, for better coverage.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/front-page_test.html (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/front-page_test.html:35: test('checks
the config set list is empty before iron ajax call',
nit: same as above - consider naming the suite & tests to read like a "story"

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/front-page_test.html:55:
front_page.searchResults);
How is configSetList generated in this test?

For the purposes of this change, it would be good to have two config sets listed
here, one valid and one invalid, and verify that they have appropriate icons (or
other relevant attributes) set.

Eventually (possibly in another CL), we should also test the search
functionality - simulate typing a search query and asserting that only matching
entries are displayed.

[ayanaadylova, 2017-07-05 18:02:45]

Ryan asked me to upload these tests but some of them are still failing.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/app.yaml (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/app.yaml:16: 
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: Please remove the white spaces in the empty line.

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:22:
<test-fixture id="projects/infra-experimental">
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: we usually try to avoid having actual production names in tests. It's OK
to
> model your data based on the real one, but it's better to rename it to
something
> obviously fake. E.g. "projects/up-to-date-project" or
> "projects/invalid-config-project".
> 
> Descriptive names like that also make the test more readable, as they suggest
> what to expect in assertions.

Done.

[ayanaadylova, 2017-07-06 22:51:44]

Added tests for config-set page and front page. 
Link to the staging version:
https://2951-32c3d35-tainted-ayanaadylova-dot-luci-config.appspot.com/newui
All tests pass in Chrome but Firefox throws errors unassociated with tests.

PTAL

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:22:
<test-fixture id="projects/infra-experimental">
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: we usually try to avoid having actual production names in tests. It's OK
to
> model your data based on the real one, but it's better to rename it to
something
> obviously fake. E.g. "projects/up-to-date-project" or
> "projects/invalid-config-project".
> 
> Descriptive names like that also make the test more readable, as they suggest
> what to expect in assertions.

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:43: test('checks
the category of config set', function() {
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: it's a good practice to name suites and tests so they sound like English
> sentences. E.g.:
>   "Up-to-date project config set"
>      - has correct category
>      - has correct  name
>      - sets isLoading by default
>      - displays valid last import attempt
> etc.
> 
> Ideally, a test suite would also read like a "story" (there is even a term
"test
> story") - where a sequence of events leads to expected assertions at each
point.
> 
> 
> See https://youtu.be/_9qARcdCAn4?t=412 for another naming sample.
> 
> Having said that, this is not a hard requirement, only a guideline.

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:68:
suite('<config-set>', function() {
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> Should the suite names be different?
> 
> The two test suites seem to be running roughly the same tests for different
> config sets, which seems redundant.
> 
> Since your change is about detecting valid vs. invalid configs, it makes sense
> to have tests for these two cases. I'd suggest to turn this second suite into
> tests for an invalid config set.

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/config-set_test.html:91:
assert.equal(config_set.files.length, 0);
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: it would be interesting to generate a few files in a config set, here or
in
> another test, for better coverage.

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
File appengine/config_service/ui/test/config-ui/front-page_test.html (right):

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/front-page_test.html:35: test('checks
the config set list is empty before iron ajax call',
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> nit: same as above - consider naming the suite & tests to read like a "story"

Done.

https://codereview.chromium.org/2959833002/diff/80001/appengine/config_servic...
appengine/config_service/ui/test/config-ui/front-page_test.html:55:
front_page.searchResults);
On 2017/06/28 19:11:35, Sergey Berezin wrote:
> How is configSetList generated in this test?
> 
> For the purposes of this change, it would be good to have two config sets
listed
> here, one valid and one invalid, and verify that they have appropriate icons
(or
> other relevant attributes) set.
> 
> Eventually (possibly in another CL), we should also test the search
> functionality - simulate typing a search query and asserting that only
matching
> entries are displayed.

Done.

[ayanaadylova, 2017-07-06 23:34:32]

Description was changed from

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.

BUG=730832
==========

to

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

[ayanaadylova, 2017-07-06 23:34:59]

Description was changed from

==========
config_service: add last import validation

In the front page user can see whether last import was successfull or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

to

==========
config_service: add last import validation

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

[ayanaadylova, 2017-07-07 18:22:13]

Description was changed from

==========
config_service: add last import validation

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

to

==========
config_service: add last import validation and tests

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

[Ryan Tseng, 2017-07-10 19:37:01]

this looks great, i have a few small comments but mostly questions.

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
File appengine/config_service/ui/src/config-ui/config-set.html (right):

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:104: <template
is="dom-if" if="[[_not(isLoading)]]">
why are some ! and some _not()?

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:203: this.files =
event.detail.response.config_sets[0].files ?
event.detail.response.config_sets[0].files || []

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:207:
event.detail.response.config_sets[0].last_import_attempt ?
event.detail.response.config_sets[0].last_import_attempt || null

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:60: '{"event": '
+
Just build a normal object and then use JSON.stringify() to convert it to a
string.  Same with all the other places with embedded json.

Also why does the server response include a javascript event object?

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:102:
config_set._onGotConfigFiles(request.response.event);
Doesn't this get triggered twice then? Once when iron-ajax completes a request
and once here?

[ayanaadylova, 2017-07-10 20:33:34]

PTAL

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
File appengine/config_service/ui/src/config-ui/config-set.html (right):

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:104: <template
is="dom-if" if="[[_not(isLoading)]]">
On 2017/07/10 19:37:01, Ryan Tseng wrote:
> why are some ! and some _not()?

Cameron used ! somewhere, but we figured out that it does not work with
functions. I changed ! to _not() to be consistent.

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:203: this.files =
event.detail.response.config_sets[0].files ?
On 2017/07/10 19:37:01, Ryan Tseng wrote:
> event.detail.response.config_sets[0].files || []

Done.

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/src/config-ui/config-set.html:207:
event.detail.response.config_sets[0].last_import_attempt ?
On 2017/07/10 19:37:01, Ryan Tseng wrote:
> event.detail.response.config_sets[0].last_import_attempt || null

Done.

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:60: '{"event": '
+
On 2017/07/10 19:37:01, Ryan Tseng wrote:
> Just build a normal object and then use JSON.stringify() to convert it to a
> string.  Same with all the other places with embedded json.
> 
> Also why does the server response include a javascript event object?

Done.

It includes a javascript event object because _onGotConfigFiles() expects object
which includes detail field. I just called it event because _onGotConfigFiles()
takes event as parameter.

https://codereview.chromium.org/2959833002/diff/120001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:102:
config_set._onGotConfigFiles(request.response.event);
On 2017/07/10 19:37:01, Ryan Tseng wrote:
> Doesn't this get triggered twice then? Once when iron-ajax completes a request
> and once here?

I thought it will trigger when when iron-ajax completes, but apparently it does
not. When I remove this line isLoading property does not get changed, that is
why I call this function manually.

[Sergey Berezin, 2017-07-10 23:53:33]

LGTM with a few nits and cosmetic comments. Thanks!

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:38: '- has
correct category' +
Let's move these sub-bullets into test names. So you'd have:

  suite('Valid project with config files', function() {
    ...
    test('has correct category', function() {
          assert.equal(config_set.category, 'projects');
    });

    test('has correct name', ...)
    ...
  }

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:60: location:
"https://chromium.googlesource.com/valid-project-with-config-files",
nit: let's make the domain name also look obviously fake, e.g.
"https://test.com/valid-project-with-config-files". Here and below.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:175:
config_set._onGotConfigFiles(request.response.event);
nit: IMHO it's OK for this CL to call the event explicitly, but let's file a bug
to figure out how to get on-response handler triggered by the element.
Also add a "TODO(crbug.com/xxxxx): make the element call on-response handler
automatically" (or similar wording).

Initial info for the bug: 
This might give us a clue on how to write such a test:
https://github.com/PolymerElements/iron-ajax/blob/master/test/iron-ajax.html#...
In particular, the test should somehow wait for the request to complete. Then
_onGotConfigFiles() will be called by the element, and we can test its
side-effects.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/front-page_test.html (right):

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/front-page_test.html:31: '- contains
2 config sets' +
Same as above - let's move these sub-bullets into test names.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/front-page_test.html:99:
front_page._onGotConfigSets(request.response.event);
nit: I'd add a "TODO(crbug.com/xxxxx): make the element call on-response handler
automatically", with the bug filed as above.

[Ryan Tseng, 2017-07-11 00:19:55]

lgtm + what sergey said

[ayanaadylova, 2017-07-11 00:23:21]

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/config-set_test.html (right):

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:38: '- has
correct category' +
On 2017/07/10 23:53:33, Sergey Berezin wrote:
> Let's move these sub-bullets into test names. So you'd have:
> 
>   suite('Valid project with config files', function() {
>     ...
>     test('has correct category', function() {
>           assert.equal(config_set.category, 'projects');
>     });
> 
>     test('has correct name', ...)
>     ...
>   }

Done.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:60: location:
"https://chromium.googlesource.com/valid-project-with-config-files",
On 2017/07/10 23:53:33, Sergey Berezin wrote:
> nit: let's make the domain name also look obviously fake, e.g.
> "https://test.com/valid-project-with-config-files". Here and below.

Done.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/config-set_test.html:175:
config_set._onGotConfigFiles(request.response.event);
On 2017/07/10 23:53:33, Sergey Berezin wrote:
> nit: IMHO it's OK for this CL to call the event explicitly, but let's file a
bug
> to figure out how to get on-response handler triggered by the element.
> Also add a "TODO(crbug.com/xxxxx): make the element call on-response handler
> automatically" (or similar wording).
> 
> Initial info for the bug: 
> This might give us a clue on how to write such a test:
>
https://github.com/PolymerElements/iron-ajax/blob/master/test/iron-ajax.html#...
> In particular, the test should somehow wait for the request to complete. Then
> _onGotConfigFiles() will be called by the element, and we can test its
> side-effects.

Done.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
File appengine/config_service/ui/test/config-ui/front-page_test.html (right):

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/front-page_test.html:31: '- contains
2 config sets' +
On 2017/07/10 23:53:33, Sergey Berezin wrote:
> Same as above - let's move these sub-bullets into test names.

Done.

https://codereview.chromium.org/2959833002/diff/140001/appengine/config_servi...
appengine/config_service/ui/test/config-ui/front-page_test.html:99:
front_page._onGotConfigSets(request.response.event);
On 2017/07/10 23:53:33, Sergey Berezin wrote:
> nit: I'd add a "TODO(crbug.com/xxxxx): make the element call on-response
handler
> automatically", with the bug filed as above.

Done.

[ayanaadylova, 2017-07-11 00:23:55]

The CQ bit was checked by ayanaadylova@google.com

[ayanaadylova, 2017-07-11 00:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, hinoka@google.com
Link to the patchset: https://codereview.chromium.org/2959833002/#ps160001
(title: "Include a bug number for making the element call on-response handler
automatically.")

[commit-bot: I haz the power, 2017-07-11 00:24:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 00:26:39]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1499732635227640,
"parent_rev": "131a21b1c390df4dd2139b4ded1bdfce9c605648", "commit_rev":
"56121b33d24c5a9fb2a8aff8247cf52f749a6952"}

[commit-bot: I haz the power, 2017-07-11 00:26:43]

Description was changed from

==========
config_service: add last import validation and tests

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832
==========

to

==========
config_service: add last import validation and tests

In the front page user can see whether last import was successful or failed.
In the config set page the appropriate error message is displayed if the last
import failed.
Added tests for front-page and config-set page.

BUG=730832

Review-Url: https://codereview.chromium.org/2959833002
Committed:
https://github.com/luci/luci-py/commit/56121b33d24c5a9fb2a8aff8247cf52f749a6952
==========

[commit-bot: I haz the power, 2017-07-11 00:26:45]

Committed patchset #9 (id:160001) as
https://github.com/luci/luci-py/commit/56121b33d24c5a9fb2a8aff8247cf52f749a6952