Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2959823003: Remove GetBlockingPool() usage in PrinterCapabilitiesTest. (Closed)

Created:
1 year, 10 months ago by Lei Zhang
Modified:
1 year, 10 months ago
Reviewers:
skau
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GetBlockingPool() usage in PrinterCapabilitiesTest. The function being tested only cares about enforcing ThreadRestrictions now. Since the unit test does not enforce ThreadRestrictions, just call the function being tested. Also put the test in the printing namespace. BUG=667892 Review-Url: https://codereview.chromium.org/2959823003 Cr-Commit-Position: refs/heads/master@{#482714} Committed: https://chromium.googlesource.com/chromium/src/+/7d380bea073931bcc05118e861ffe2d8fe0d9403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -44 lines) Patch
M chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc View 4 chunks +16 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
1 year, 10 months ago (2017-06-27 17:40:25 UTC) #6
skau
lgtm
1 year, 10 months ago (2017-06-27 19:19:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959823003/1
1 year, 10 months ago (2017-06-27 19:38:21 UTC) #9
commit-bot: I haz the power
1 year, 10 months ago (2017-06-27 19:42:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d380bea073931bcc05118e861ff...

Powered by Google App Engine
This is Rietveld 408576698