Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2959783002: And Timeout expectations for two new Bluetooth tests. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
ortuno, scottmg
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

And Timeout expectations for two new Bluetooth tests. There are already similar expectations for a bunch of pre-existing ones. The new ones are: bluetooth/characteristic/writeValue/write-succeeds.html added in https://chromium-review.googlesource.com/542755 bluetooth/descriptor/readValue/read-succeeds.html added in LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html BUG=729849 TBR=scottmg@chromium.org, ortuno@chromium.org Review-Url: https://codereview.chromium.org/2959783002 Cr-Commit-Position: refs/heads/master@{#482332} Committed: https://chromium.googlesource.com/chromium/src/+/28d381082211e0ba9199c8c8de35ff77cda44066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mmenke
ortuno: Would you mind pre-emptively adding Network Serivce suppressions for future bluetooth tests you add? ...
3 years, 5 months ago (2017-06-26 16:57:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959783002/1
3 years, 5 months ago (2017-06-26 16:58:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/28d381082211e0ba9199c8c8de35ff77cda44066
3 years, 5 months ago (2017-06-26 18:33:57 UTC) #10
ortuno
Oh interesting. Do we know why they are failing? In my case I'm not adding ...
3 years, 5 months ago (2017-06-26 23:46:54 UTC) #11
mmenke
3 years, 5 months ago (2017-06-26 23:48:41 UTC) #12
Message was sent while issue was closed.
On 2017/06/26 23:46:54, ortuno wrote:
> Oh interesting. Do we know why they are failing? In my case I'm not adding any
> new tests just refactoring some tests to use Mojo.

No clue.

Powered by Google App Engine
This is Rietveld 408576698