Add comment warning about modifying landmines

Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

This was inspired by https://chromium-review.googlesource.com/c/544867/

R=dpranke@chromium.org
BUG=736939
Review-Url: https://codereview.chromium.org/2959743004
Cr-Commit-Position: refs/heads/master@{#482639}
Committed: https://chromium.googlesource.com/chromium/src/+/46ac6b742672a82001cd3d8ef0c7525be72a9097

[brucedawson, 2017-06-26 23:43:17]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 23:43:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-06-26 23:44:11]

Does this seem appropriate?

We could also assign explicit OWNERS to further discourage landmines.

I used to be a serial violator of this rule but I am now reformed.

[brucedawson, 2017-06-26 23:47:13]

Description was changed from

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

This was inspired by https://chromium-review.googlesource.com/c/544867/

R=dpranke@chromium.org
==========

to

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

This was inspired by https://chromium-review.googlesource.com/c/544867/

R=dpranke@chromium.org
BUG=736939
==========

[commit-bot: I haz the power, 2017-06-27 00:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 00:02:02]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-06-27 00:32:21]

I think this looks fine (lgtm) though I don't think it'll matter much.

Apart from making them undoable, I'm tempted to say that we should add an "are
you sure" presubmit warning or something ...

[brucedawson, 2017-06-27 16:00:51]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-06-27 16:01:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-06-27 16:02:24]

On 2017/06/27 00:32:21, Dirk Pranke wrote:
> I think this looks fine (lgtm) though I don't think it'll matter much.
> 
> Apart from making them undoable, I'm tempted to say that we should add an "are
> you sure" presubmit warning or something ...

Agreed.

[commit-bot: I haz the power, 2017-06-27 16:04:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498579251554700, "parent_rev":
"eafc049ccec45550ea86089c463918131d04e927", "commit_rev":
"46ac6b742672a82001cd3d8ef0c7525be72a9097"}

[commit-bot: I haz the power, 2017-06-27 16:05:04]

Description was changed from

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

This was inspired by https://chromium-review.googlesource.com/c/544867/

R=dpranke@chromium.org
BUG=736939
==========

to

==========
Add comment warning about modifying landmines

Modifying landmines has greater consequences than is sometimes realized
for developers, especially on Windows. Add a comment to warn editors of
these consequences.

This was inspired by https://chromium-review.googlesource.com/c/544867/

R=dpranke@chromium.org
BUG=736939

Review-Url: https://codereview.chromium.org/2959743004
Cr-Commit-Position: refs/heads/master@{#482639}
Committed:
https://chromium.googlesource.com/chromium/src/+/46ac6b742672a82001cd3d8ef0c7...
==========

[commit-bot: I haz the power, 2017-06-27 16:05:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46ac6b742672a82001cd3d8ef0c7...

[Nico, 2017-06-27 16:09:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-06-27 16:09:21]

Do you think anyone will look at this file? landmines are added to
get_landmines.py, which already has a comment like this. I suppose we could copy
the comment in get_landmines.py from the top to the bottom too, so it's more in
sight.

But adding the comment to this file seems unlikely to help.

[brucedawson, 2017-06-27 17:47:31]

On 2017/06/27 16:09:21, Nico (vacation Jun 30-Jul 11) wrote:
> Do you think anyone will look at this file? landmines are added to
> get_landmines.py, which already has a comment like this. I suppose we could
copy
> the comment in get_landmines.py from the top to the bottom too, so it's more
in
> sight.
> 
> But adding the comment to this file seems unlikely to help.

Drat. Yep, wrong file. I'll add the warnings to the correct file.