Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2959693002: Simplify OfflineAudioDestinationNode::DoOfflineRendering(). (Closed)

Created:
3 years, 5 months ago by sof
Modified:
3 years, 5 months ago
Reviewers:
hongchan, Raymond Toy
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify OfflineAudioDestinationNode::DoOfflineRendering(). No need to track is-suspended state. R=hongchan BUG=736429 Review-Url: https://codereview.chromium.org/2959693002 Cr-Commit-Position: refs/heads/master@{#482417} Committed: https://chromium.googlesource.com/chromium/src/+/250ea0ea4174a17b0aa1c9a72a892df2b5aa5043

Patch Set 1 #

Patch Set 2 : rebased upto r482341 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 3 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sof
please take a look. just a minor code detail noticed while looking at this method.
3 years, 5 months ago (2017-06-26 12:49:30 UTC) #4
hongchan
lgtm
3 years, 5 months ago (2017-06-26 15:33:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959693002/20001
3 years, 5 months ago (2017-06-26 19:14:32 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 21:37:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/250ea0ea4174a17b0aa1c9a72a89...

Powered by Google App Engine
This is Rietveld 408576698