Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2959673002: Revert of Disable RTCVideoRenderFrameCallbackNV12 test (Closed)

Created:
3 years, 5 months ago by magjed_webrtc
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disable RTCVideoRenderFrameCallbackNV12 test (patchset #1 id:20001 of https://codereview.webrtc.org/2951273002/ ) Reason for revert: Test has been fixed. Original issue's description: > Disable RTCVideoRenderFrameCallbackNV12 test > > It has been crashing on trybots > > BUG=webrtc:7863 > TBR=magjed@webrtc.org > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2951273002 > Cr-Commit-Position: refs/heads/master@{#18720} > Committed: https://chromium.googlesource.com/external/webrtc/+/4d25a0554a4bde9d76de5f3728fa181ba82fb0e1 TBR=kjellander@webrtc.org,oprypin@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7863 Review-Url: https://codereview.webrtc.org/2959673002 Cr-Commit-Position: refs/heads/master@{#18758} Committed: https://chromium.googlesource.com/external/webrtc/+/587ff112089bb4da22d6b6796dedc027fd8425bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
magjed_webrtc
Created Revert of Disable RTCVideoRenderFrameCallbackNV12 test
3 years, 5 months ago (2017-06-26 09:34:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2959673002/1
3 years, 5 months ago (2017-06-26 09:35:00 UTC) #3
kjellander_webrtc
lgtm
3 years, 5 months ago (2017-06-26 09:43:25 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 10:11:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/587ff112089bb4da22d6b6796...

Powered by Google App Engine
This is Rietveld 408576698