Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2959663002: Repost offline rendering task if GC prevents. (Closed)

Created:
3 years, 5 months ago by sof
Modified:
3 years, 5 months ago
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Repost offline rendering task if GC prevents. R= BUG=736429 Review-Url: https://codereview.chromium.org/2959663002 Cr-Commit-Position: refs/heads/master@{#482301} Committed: https://chromium.googlesource.com/chromium/src/+/83bd4101c86370d76a76a0e890d82ae66618f6ba

Patch Set 1 #

Patch Set 2 : do want to try-lock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
sof
please take a look. speculative as it isn't reproducing here.
3 years, 5 months ago (2017-06-26 10:41:54 UTC) #7
haraken
LGTM to try
3 years, 5 months ago (2017-06-26 11:10:05 UTC) #8
hongchan
lgtm. Thanks so much for working on this!
3 years, 5 months ago (2017-06-26 15:34:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959663002/20001
3 years, 5 months ago (2017-06-26 17:06:00 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 17:12:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83bd4101c86370d76a76a0e890d8...

Powered by Google App Engine
This is Rietveld 408576698