[Extensions Bindings] Don't load lastError module with native bindings

[Extensions Bindings] Don't load lastError module with native bindings

Setting the lastError property is implemented natively with native
bindings, and the JS version should never be used. Don't load the
lastError module when native bindings are enabled to enforce this.

BUG=653596
Review-Url: https://codereview.chromium.org/2959583002
Cr-Commit-Position: refs/heads/master@{#485073}
Committed: https://chromium.googlesource.com/chromium/src/+/2a53188b33dfeb1efeb6bf961b8c67b82f5de2ca

[Devlin, 2017-06-26 16:03:33]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 16:03:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 16:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 16:47:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-26 18:55:01]

Description was changed from

==========
blacklist lasterror
BUG=
==========

to

==========
[Extensions Bindings] Don't load lastError module with native bindings

Setting the lastError property is implemented natively with native
bindings, and the JS version should never be used. Don't load the
lastError module when native bindings are enabled to enforce this.

BUG=653596
==========

[Devlin, 2017-06-26 19:58:16]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 19:58:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 20:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 20:31:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-26 20:40:53]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 20:41:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 21:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:55:08]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-26 21:58:49]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-06-26 21:58:50]

lazyboy@, can you take a look?

jbroman@, FYI.

[lazyboy, 2017-07-06 22:02:00]

lgtm

[Devlin, 2017-07-07 00:24:14]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-07-07 00:24:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 00:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 00:28:01]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Devlin, 2017-07-07 20:17:17]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 20:17:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 21:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 21:44:51]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-07-07 22:19:00]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-07-07 22:19:00]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2959583002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-07-07 22:19:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 22:24:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499465940043520,
"parent_rev": "192074239bdc37b0821e4df3a667ddf8dd4c544f", "commit_rev":
"2a53188b33dfeb1efeb6bf961b8c67b82f5de2ca"}

[commit-bot: I haz the power, 2017-07-07 22:24:35]

Description was changed from

==========
[Extensions Bindings] Don't load lastError module with native bindings

Setting the lastError property is implemented natively with native
bindings, and the JS version should never be used. Don't load the
lastError module when native bindings are enabled to enforce this.

BUG=653596
==========

to

==========
[Extensions Bindings] Don't load lastError module with native bindings

Setting the lastError property is implemented natively with native
bindings, and the JS version should never be used. Don't load the
lastError module when native bindings are enabled to enforce this.

BUG=653596

Review-Url: https://codereview.chromium.org/2959583002
Cr-Commit-Position: refs/heads/master@{#485073}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a53188b33dfeb1efeb6bf961b8c...
==========

[commit-bot: I haz the power, 2017-07-07 22:24:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2a53188b33dfeb1efeb6bf961b8c...