Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2959523002: Revert of ChromeOS: Enable Gaia v2 API by default. (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS: Enable Gaia v2 API by default. (patchset #6 id:100001 of https://codereview.chromium.org/2952903002/ ) Reason for revert: Will re-land after the Gaia v2 API is completely ready. For now it shows 404 error. This also affects the user pod placement, Please see crbug.com/736467 Original issue's description: > ChromeOS: Enable Gaia v2 API by default. > > BUG=709244 > > Review-Url: https://codereview.chromium.org/2952903002 > Cr-Commit-Position: refs/heads/master@{#481630} > Committed: https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f6795181951525b TBR=achuith@chromium.org,msarda@chromium.org,alemate@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709244, 736467 Review-Url: https://codereview.chromium.org/2959523002 Cr-Commit-Position: refs/heads/master@{#482081} Committed: https://chromium.googlesource.com/chromium/src/+/47da9855562f7261d9b10ad91fb6fe3c6688abd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +1 line, -4 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 2 chunks +2 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 3 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Wenzhao (Colin) Zang
Created Revert of ChromeOS: Enable Gaia v2 API by default.
3 years, 6 months ago (2017-06-23 22:31:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959523002/1
3 years, 6 months ago (2017-06-23 22:31:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-23 22:31:34 UTC) #5
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-23 22:32:59 UTC) #8
xiyuan
lgtm You might want to add 736467 to the bug list as well (or update ...
3 years, 6 months ago (2017-06-23 22:34:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959523002/1
3 years, 6 months ago (2017-06-23 23:59:39 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/47da9855562f7261d9b10ad91fb6fe3c6688abd6
3 years, 6 months ago (2017-06-24 00:04:22 UTC) #19
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-24 00:06:02 UTC) #20
Message was sent while issue was closed.
On 2017/06/23 22:34:26, xiyuan wrote:
> lgtm
> 
> You might want to add 736467 to the bug list as well (or update the bug with
> this revert).

Done. Thanks.

Powered by Google App Engine
This is Rietveld 408576698