Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 295933003: Add a message for the SelectMenuListText identifier (Closed)

Created:
6 years, 7 months ago by dtrebbien
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, abarth-chromium, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a message for the SelectMenuListText identifier Depends on https://codereview.chromium.org/280483002/ BUG=314704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272351

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
dtrebbien
6 years, 7 months ago (2014-05-20 11:32:28 UTC) #1
michaeln
r/s lgtm
6 years, 7 months ago (2014-05-20 19:21:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/295933003/diff/1/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): https://codereview.chromium.org/295933003/diff/1/webkit/glue/webkit_strings.grd#newcode303 webkit/glue/webkit_strings.grd:303: <ph name="SELECTED_COUNT">$1<ex>3</ex></ph> selected Should we include what was ...
6 years, 7 months ago (2014-05-21 08:50:32 UTC) #3
dtrebbien
On 2014/05/21 08:50:32, jochen wrote: > lgtm > > https://codereview.chromium.org/295933003/diff/1/webkit/glue/webkit_strings.grd > File webkit/glue/webkit_strings.grd (right): > ...
6 years, 7 months ago (2014-05-21 12:07:35 UTC) #4
jochen (gone - plz use gerrit)
thanks for the clarification
6 years, 7 months ago (2014-05-21 12:24:24 UTC) #5
dtrebbien
The CQ bit was checked by dtrebbien@gmail.com
6 years, 7 months ago (2014-05-22 10:47:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrebbien@gmail.com/295933003/1
6 years, 7 months ago (2014-05-22 10:48:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:50:15 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 22:50:16 UTC) #9
Message was sent while issue was closed.
Change committed as 272351

Powered by Google App Engine
This is Rietveld 408576698