Update faster builds instructions

Update faster builds instructions

The instructions in windows_build_instructions.md for getting faster
builds omitted any mention of settings that can help. This adds
a list of settings along with their pros and cons.

This will update:
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#Faster-builds

Testing of the markdown was done by pasting it into http://dillinger.io/.

Review-Url: https://codereview.chromium.org/2959293002
Cr-Commit-Position: refs/heads/master@{#484692}
Committed: https://chromium.googlesource.com/chromium/src/+/cfc7fd5c6e4107f93bc7621f526c9abf1a19ed33

[brucedawson, 2017-06-28 21:44:38]

Description was changed from

==========
Update faster builds instructions

The instructions in windows_build_instructions.md for getting faster
builds omitted any mention of settings that can help. This adds
a list of settings along with their pros and cons.
==========

to

==========
Update faster builds instructions

The instructions in windows_build_instructions.md for getting faster
builds omitted any mention of settings that can help. This adds
a list of settings along with their pros and cons.

This will update:
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...

Testing of the markdown was done by pasting it into http://dillinger.io/.
==========

[brucedawson, 2017-07-06 00:52:17]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2017-07-06 00:52:17]

Whadya think? It's time to make some of these build options more discoverable.

[Dirk Pranke, 2017-07-06 01:56:20]

lgtm w/ the nit addressed.

https://codereview.chromium.org/2959293002/diff/80001/docs/windows_build_inst...
File docs/windows_build_instructions.md (right):

https://codereview.chromium.org/2959293002/diff/80001/docs/windows_build_inst...
docs/windows_build_instructions.md:200: (`gn gen out/Default
--args="is_component_build = false is_debug = true"`).
is_component_build=false is_debug=true won't even build, will it? That seems
like a bad example :).

[brucedawson, 2017-07-06 18:00:24]

Not actually a wrong example, but probably a sub-optimal example, so fixed.

https://codereview.chromium.org/2959293002/diff/80001/docs/windows_build_inst...
File docs/windows_build_instructions.md (right):

https://codereview.chromium.org/2959293002/diff/80001/docs/windows_build_inst...
docs/windows_build_instructions.md:200: (`gn gen out/Default
--args="is_component_build = false is_debug = true"`).
On 2017/07/06 01:56:19, Dirk Pranke wrote:
> is_component_build=false is_debug=true won't even build, will it? That seems
> like a bad example :).

A debug non-component build works fine (I just double-checked by pasting the
command into a command-prompt and then building 'base' from that output
directory). I actually do debug non-component builds fairly frequently, but it
is an odd combination. I'm changing it to be the more normal debug component
build.

[Dirk Pranke, 2017-07-06 18:09:46]

On 2017/07/06 18:00:24, brucedawson wrote:
> A debug non-component build works fine (I just double-checked by pasting the
> command into a command-prompt and then building 'base' from that output
> directory). I actually do debug non-component builds fairly frequently, but it
> is an odd combination. I'm changing it to be the more normal debug component
> build.

I thought that actually stopped working at some point due to toolchain
limitations; maybe that was 2015 or 2013 ...

[brucedawson, 2017-07-06 18:21:57]

> I thought that actually stopped working at some point due to toolchain
> limitations; maybe that was 2015 or 2013 ...

Trivia: due to parallelism limitations in component builds the fastest Chrome
build possible is actually a debug non-component build. The fastest build with
full symbols is a debug component build. I don't know if debug non-component
builds used to not work - before my time I think. Landing now.

[brucedawson, 2017-07-06 18:22:03]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2017-07-06 18:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2959293002/#ps100001
(title: "Change example")

[commit-bot: I haz the power, 2017-07-06 18:22:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 18:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1499365323571080,
"parent_rev": "2573af0cb05d9f2bcacebf3b147d1659d23114c0", "commit_rev":
"cfc7fd5c6e4107f93bc7621f526c9abf1a19ed33"}

[commit-bot: I haz the power, 2017-07-06 18:41:15]

Description was changed from

==========
Update faster builds instructions

The instructions in windows_build_instructions.md for getting faster
builds omitted any mention of settings that can help. This adds
a list of settings along with their pros and cons.

This will update:
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...

Testing of the markdown was done by pasting it into http://dillinger.io/.
==========

to

==========
Update faster builds instructions

The instructions in windows_build_instructions.md for getting faster
builds omitted any mention of settings that can help. This adds
a list of settings along with their pros and cons.

This will update:
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...

Testing of the markdown was done by pasting it into http://dillinger.io/.

Review-Url: https://codereview.chromium.org/2959293002
Cr-Commit-Position: refs/heads/master@{#484692}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfc7fd5c6e4107f93bc7621f526c...
==========

[commit-bot: I haz the power, 2017-07-06 18:41:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/cfc7fd5c6e4107f93bc7621f526c...