Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/search.dart

Issue 2959273002: Report only private members in the same library as overrides. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/analysis/search.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/search.dart b/pkg/analyzer/lib/src/dart/analysis/search.dart
index b10e815b17ce5f346ae8c37c55e3a9d7aa203a7e..7e44b8380d5addb5c455638ace47f037dfdc94d6 100644
--- a/pkg/analyzer/lib/src/dart/analysis/search.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/search.dart
@@ -148,6 +148,7 @@ class Search {
if (subtype.supertypes.contains(id)) {
FileState library = file.isPart ? file.library : file;
results.add(new SubtypeResult(
+ library.uriStr,
library.uriStr + ';' + file.uriStr + ';' + subtype.name,
subtype.name,
subtype.members));
@@ -544,6 +545,11 @@ enum SearchResultKind { READ, READ_WRITE, WRITE, INVOCATION, REFERENCE }
*/
class SubtypeResult {
/**
+ * The URI of the library.
+ */
+ final String libraryUri;
+
+ /**
* The identifier of the subtype.
*/
final String id;
@@ -554,11 +560,11 @@ class SubtypeResult {
final String name;
/**
- * The names of members declared in the class.
+ * The names of instance members declared in the class.
*/
final List<String> members;
- SubtypeResult(this.id, this.name, this.members);
+ SubtypeResult(this.libraryUri, this.id, this.name, this.members);
@override
String toString() => id;
« no previous file with comments | « pkg/analysis_server/test/services/search/search_engine_test.dart ('k') | pkg/analyzer/test/src/dart/analysis/search_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698